From cc56fc2d8c867a6b007f93a3798507e4670d11b8 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Tue, 30 Dec 2025 09:49:39 -0600 Subject: [PATCH] sync/git(fix[update_repo]): Use quiet=True for stash.save why: The code incorrectly passed "--quiet" as the message parameter, creating stashes with literal "--quiet" message instead of suppressing output. what: - Change stash.save(message="--quiet") to stash.save(quiet=True) - Remove unused git_stash_save_options variable - Remove outdated Git < 1.7.6 comment --- CHANGES | 6 ++++++ src/libvcs/sync/git.py | 4 +--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGES b/CHANGES index 2aa6ea5f..db6d0fc1 100644 --- a/CHANGES +++ b/CHANGES @@ -20,6 +20,12 @@ $ uv add libvcs --prerelease allow _Notes on the upcoming release will go here._ +### Bug fixes + +#### Fix stash.save() quiet parameter usage (#506) + +- Fixed `GitSync.update_repo()` to use `stash.save(quiet=True)` instead of incorrectly passing `"--quiet"` as the message parameter + ## libvcs 0.40.0 (2026-04-25) ### What's new diff --git a/src/libvcs/sync/git.py b/src/libvcs/sync/git.py index 42d3f98f..d97996e2 100644 --- a/src/libvcs/sync/git.py +++ b/src/libvcs/sync/git.py @@ -551,10 +551,8 @@ def update_repo( # If not in clean state, stash changes in order to be able # to be able to perform git pull --rebase if need_stash: - # If Git < 1.7.6, uses --quiet --all - git_stash_save_options = "--quiet" try: - process = self.cmd.stash.save(message=git_stash_save_options) + process = self.cmd.stash.save(quiet=True) except exc.CommandError as e: self.log.exception("Failed to stash changes") result.add_error("stash-save", str(e), exception=e)