NoMethodError: undefined method `dev' for nil:NilClass

[karlkfi]

The current BOSH code (specifically the BATs) does not seem to work with the bosh_vcloud_cpi. The problem seems to have been caused by the recent move to using Logging::Logger instead of ruby's Logger. The new logger has a similar API to the ruby logger, but is not an extention. So it's not entirely reverse compatible.

It seems that ruby_vcloud_sdk is expecting a Logger type object and then using reflection to access the @logdev instance variable in order to find the file path of the log device, but there is no @logdev variable in Logging::Logger.

https://github.com/vchs/ruby_vcloud_sdk/blob/master/lib/ruby_vcloud_sdk/connection/connection.rb#L164

I'm not entirely sure what a desirable solution is in this case, but it's probably a bad idea to use reflection on an injected object, especially without verifying it's type.

Logging::Logger uses appenders to designate where the logs go. Multiple appenders are supported per logger. So even if you need to continue reaching into the logger, it might be more difficult to determine what file to log to unless both bosh_vcloud_cpi and ruby_vcloud_sdk also switch to using Logging::Logger.

It looks like the 'rest_logger' is actually a new file. Is it important that it be next to the other CPI logs? If not it might be desirable to inject a different file path or use a temp file.

bosh_vcloud_cpi cannot be bumped in bosh until this is resolved. How would you like to proceed?

[karlkfi]

For reference: Logging::Logger

[molteanu]

If I remember correctly the purpose of the code that looks into the Logger object was to determine the path for the file for the rest-logger. (We wanted to have split logs if possible) As you can see from the "else" branch if we cannot determine the path from the Logger we default to sending the rest log messages to the default logger.

There are 2 approaches to fix this:

• Make sure L164 does not fail with the NoMethodError and ensure that the "else" branch is taken when the logger does not have a @logdev variable
• Don't build a separate logger instance for the rest_logger and just the member variable to Config.logger. (Basically keep L175 in that method.)

Can you send a pull request for either of the fixes? (Thats probably the quickest way to get this fixed.)

[karlkfi]

There's a 3rd option using the Logging library, if you want to add the logging library as a dependency.

We could check if Config.logger is a Logging::Logger, loop through logger.appenders.each to find one that is a Logging::Appenders::File, and then call appender.filename to get the filename.

That wouldn't require any reflection, but would add a library dependency. I'm not sure if you want to add the dependency and then not upgrade the rest of the cpi to use it for logging...

FYI, we have an open chore to upgrade all the rest of the bosh components to use Logging::Logger, including the other cpis.

[molteanu]

Lets go with one of the fixes that does not require adding a dependency to the new lib. We can think about upgrading the SDK once the CPIs have been upgraded.