df -m no longer works

[peabee]

In the old coreutils df -m displays in megabytes

the -m switch is however not shown in Man or shown in df --help - this is probably an oversight?

the alternative format is df -BM

in the new coreutils df -m throws a wobbly - unknown switch

for backward compatibility could df -m behave the same as df -BM ?

[oech3]

This might one of a good 1st issue since it can be solved by just adjusting clap's config at

coreutils/src/uu/df/src/df.rs

Line 500 in ff89074

pub fn uu_app() -> Command {

. Do you try to send a PR?

[peabee]

This might one of a good 1st issue since it can be solved by just adjusting clap's config at

coreutils/src/uu/df/src/df.rs

Line 500 in ff89074

pub fn uu_app() -> Command {
. Do you try to send a PR?

This is my first ever encounter with Rust so I would be very uncertain in my ability to form a viable PR.......

I don't see where -BM is specified.........

I assume an entry like df -k is needed:

        Arg::new(OPT_KILO)
            .short('k')
            .help(translate!("df-help-kilo"))
            .overrides_with_all([OPT_BLOCKSIZE, OPT_KILO])
            .action(ArgAction::SetTrue),
    )

but what else? df-help-mega ? OPT_MEGA ?

Some hand-holding would definitely be needed ;-)

[oech3]

translate! loads from

coreutils/src/uu/df/locales/en-US.ftl

Line 20 in 0beca7c

df-help-kilo = like --block-size=1K

and flags are just

coreutils/src/uu/df/src/df.rs

Line 41 in 0beca7c

static OPT_KILO: &str = "kilo";

[oech3]

Yu can just add similar things for the missing flag.
There is fr-FR.ftl, but en-US should work as a fallback.

[peabee]

The outputs for df -m & df -BM (also df -k & df -BK) do differ slightly........ the -B versions add "M" (or "K") to the numbers:

df -m

Filesystem 1M-blocks Used Available Use% Mounted on
tmpfs 4488 514 3974 12% /initrd/mnt/tmpfs

df -BM

Filesystem 1M-blocks Used Available Use% Mounted on
tmpfs 4488M 514M 3974M 12% /initrd/mnt/tmpfs

df -k

Filesystem 1K-blocks Used Available Use% Mounted on
tmpfs 4595268 526188 4069080 12% /initrd/mnt/tmpfs

df -BK

Filesystem 1K-blocks Used Available Use% Mounted on
tmpfs 4595268K 526188K 4069080K 12% /initrd/mnt/tmpfs

[peabee]

To confirm, I should issue a PR which??:

at about line 577 of coreutils/src/uu/df/src/df.rs adds:
.arg(
Arg::new(OPT_MEGA)
.short('m')
.help(translate!("df-help-mega"))
.overrides_with_all([OPT_BLOCKSIZE, OPT_MEGA])
.action(ArgAction::SetTrue),
)

at about line 22 of coreutils/src/uu/df/locales/en-US.ftl adds:
df-help-mega = like --block-size=1M

at about line 43 of coreutils/src/uu/df/src/df.rs adds:
static OPT_MEGA: &str = "mega";

[oech3]

We might need additional logic for #11565 (comment) .
This might not too easy as I considered at 1st.

[peabee]

Where is the code that implements df -BM ?
I can't find it........