remove unknown warnings in Eclipse

PhilippSalvisberg · PhilippSalvisberg · commit bfe7ffe7909f · 2020-12-27T20:56:12.000+01:00
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java b/sqldev/src/main/java/org/utplsql/sqldev/dal/RealtimeReporterDao.java
@@ -52,7 +52,6 @@
 
 import oracle.jdbc.OracleTypes;
 
-@SuppressWarnings("StringBufferReplaceableByString")
 public class RealtimeReporterDao {
     private static final Logger logger = Logger.getLogger(RealtimeReporterDao.class.getName());
     private static final int FIRST_VERSION_WITH_REALTIME_REPORTER = 3001004;
@@ -246,7 +245,6 @@ private RealtimeReporterEvent convert(final String itemType, final String text)
         }
     }
 
-    @SuppressWarnings("DuplicatedCode")
     private RealtimeReporterEvent convertToPreRunEvent(final Document doc) {
         final PreRunEvent event = new PreRunEvent();
         final Node totalNumberOfTestsNode = xmlTools.getNode(doc, "/event/totalNumberOfTests");
@@ -327,7 +325,6 @@ private RealtimeReporterEvent convertToPostTestEvent(final Document doc) {
         return event;
     }
 
-    @SuppressWarnings("DuplicatedCode")
     private void populate(final Suite suite, final Node node) {
         if (node instanceof Element) {
             suite.setId(xmlTools.getAttributeValue(node, "id"));
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/runner/UtplsqlRunner.java b/sqldev/src/main/java/org/utplsql/sqldev/runner/UtplsqlRunner.java
@@ -152,7 +152,6 @@ public void dispose() {
         run.setConsumerConn(null);
     }
 
-    @SuppressWarnings("StatementWithEmptyBody")
     @Override
     public void process(final RealtimeReporterEvent event) {
         logger.fine(event::toString);
diff --git a/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java b/sqldev/src/main/java/org/utplsql/sqldev/ui/runner/RunnerPanel.java
@@ -291,7 +291,6 @@ private void applyFilter(final boolean showSuccessfulTests, final boolean showDi
         @SuppressWarnings("unchecked")
         final TableRowSorter<TestOverviewTableModel> sorter = ((TableRowSorter<TestOverviewTableModel>) testOverviewTable.getRowSorter());
         final RowFilter<TestOverviewTableModel, Integer> filter = new RowFilter<TestOverviewTableModel, Integer>() {
-            @SuppressWarnings("RedundantIfStatement")
             @Override
             public boolean include(final RowFilter.Entry<? extends TestOverviewTableModel, ? extends Integer> entry) {
                 final Test test = entry.getModel().getTest((entry.getIdentifier()).intValue());
@@ -344,7 +343,6 @@ private void openSelectedFailure() {
         }
     }
 
-    @SuppressWarnings("StringBufferReplaceableByString")
     private String getHtml(final String text) {
         StringBuilder sb = new StringBuilder();
         sb.append("<html>\n");
@@ -381,7 +379,6 @@ private void openLink(final String link) {
         openEditor(ownerName, objectType, objectName.toUpperCase(), line, 1);
     }
 
-    @SuppressWarnings("SameParameterValue")
     private void openEditor(final String owner, final String type, final String name, final int line, final int col) {
         DefaultDrillLink drillLink = new DefaultDrillLink();
         drillLink.setConnName(currentRun.getConnectionName());
@@ -744,7 +741,6 @@ private void fixCountersAndUpdate() {
         update(currentRun.getReporterId());
     }
 
-    @SuppressWarnings("DuplicatedCode")
     private void initializeGUI() {
         // Base panel containing all components 
         basePanel = new JPanel();
diff --git a/sqldev/src/test/java/org/utplsql/sqldev/test/JsonToStringStylerTest.java b/sqldev/src/test/java/org/utplsql/sqldev/test/JsonToStringStylerTest.java
@@ -22,7 +22,6 @@
 import org.utplsql.sqldev.model.runner.Run;
 import org.utplsql.sqldev.model.ut.OutputLines;
 
-@SuppressWarnings("StringBufferReplaceableByString")
 public class JsonToStringStylerTest {
 
     @Test

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@`
`52`	`52`
`53`	`53`	`import oracle.jdbc.OracleTypes;`
`54`	`54`
`55`		`-@SuppressWarnings("StringBufferReplaceableByString")`
`56`	`55`	`public class RealtimeReporterDao {`
`57`	`56`	`private static final Logger logger = Logger.getLogger(RealtimeReporterDao.class.getName());`
`58`	`57`	`private static final int FIRST_VERSION_WITH_REALTIME_REPORTER = 3001004;`
`@@ -246,7 +245,6 @@ private RealtimeReporterEvent convert(final String itemType, final String text)`
`246`	`245`	`}`
`247`	`246`	`}`
`248`	`247`
`249`		`- @SuppressWarnings("DuplicatedCode")`
`250`	`248`	`private RealtimeReporterEvent convertToPreRunEvent(final Document doc) {`
`251`	`249`	`final PreRunEvent event = new PreRunEvent();`
`252`	`250`	`final Node totalNumberOfTestsNode = xmlTools.getNode(doc, "/event/totalNumberOfTests");`
`@@ -327,7 +325,6 @@ private RealtimeReporterEvent convertToPostTestEvent(final Document doc) {`
`327`	`325`	`return event;`
`328`	`326`	`}`
`329`	`327`
`330`		`- @SuppressWarnings("DuplicatedCode")`
`331`	`328`	`private void populate(final Suite suite, final Node node) {`
`332`	`329`	`if (node instanceof Element) {`
`333`	`330`	`suite.setId(xmlTools.getAttributeValue(node, "id"));`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ public void dispose() {`
`152`	`152`	`run.setConsumerConn(null);`
`153`	`153`	`}`
`154`	`154`
`155`		`- @SuppressWarnings("StatementWithEmptyBody")`
`156`	`155`	`@Override`
`157`	`156`	`public void process(final RealtimeReporterEvent event) {`
`158`	`157`	`logger.fine(event::toString);`