rename rascal-p2-dependencies-repackaged to rascal-jdt-repackaged?

[jurgenvinju]

now that we have a rascal-cdt-repackaged the original name does not make sense anymore.

I'm looking for (dis)agreement. If you agree, please mark, otherwise, please contribute a discussion:

• @DavyLandman
• @PaulKlint
• @tvdstorm

The only project that depends on the rascal-p2-dependencies-repackaged project is the rascal project; it depends on the latest release 0.5.0.

[jurgenvinju]

the project currently packages jdt.core and some eclipse core packages that jdt requires.

[DavyLandman]

sounds good to me, it used to package more, but we slowly took out stuff.

[DavyLandman]

hmm, wait, it also contains com.ibm.icu.base which we still use for our date time logic.

[jurgenvinju]

can't we get that dependency from a normal jar?

[DavyLandman]

no idea, maybe: https://mavenlibs.com/maven/dependency/com.ibm.icu/icu4j ?

[jurgenvinju]

Ok. Will have to check version numbers and stuff, but that seems the best. more dependencies in the "normal" way and fewer via Tycho and MANIFEST.MF.

[jurgenvinju]

[INFO] Unpacking /Users/jurgenv/.m2/repository/p2/osgi/bundle/com.ibm.icu/64.2.0.v20190507-1337/com.ibm.icu-64.2.0.v20190507-1337.jar to /Users/jurgenv/git/rascal-p2-dependencies-repackaged/target/dependency with includes "" and excludes ""

com.ibm.icu comes with the JDT whether we have it listed as dependency or not. So we can not remove it here, and so we should not add it elsewhere to avoid weird version conflicts in the rascal fat.jar

[DavyLandman]

ah, I think I might added the .base one just to decrease the size of the jar. so yeah, keep it like this.