Merge pull request #6 from istagir/master

Merging fixes for Issue #3 (exception.StackTrace is truncated)

Author: ENikS

src/Interceptors/InstanceInterceptors/InterfaceInterception/InterfaceMethodOverride.cs

@@ -414,7 +414,17 @@ private MethodBuilder CreateMethodOverride(MethodBuilder delegateMethod)
             il.Emit(OpCodes.Ceq);
             il.Emit(OpCodes.Brtrue_S, noException);
             il.Emit(OpCodes.Ldloc, ex);
-            il.Emit(OpCodes.Throw);
+
+            if (ReflectionHelper.ExceptionDispatchInfoCaptureMethod != null
+                && ReflectionHelper.ExceptionDispatchInfoThrowMethod != null)
+            {
+                il.EmitCall(OpCodes.Call, ReflectionHelper.ExceptionDispatchInfoCaptureMethod, null);
+                il.EmitCall(OpCodes.Callvirt, ReflectionHelper.ExceptionDispatchInfoThrowMethod, null);
+            }
+            else
+            {
+                il.Emit(OpCodes.Throw);
+            }
 
             il.MarkLabel(noException);
 

src/Interceptors/TypeInterceptors/VirtualMethodInterception/InterceptingClassGeneration/MethodOverride.cs

@@ -416,7 +416,17 @@ private MethodBuilder CreateMethodOverride(MethodBuilder delegateMethod)
             il.Emit(OpCodes.Ceq);
             il.Emit(OpCodes.Brtrue_S, noException);
             il.Emit(OpCodes.Ldloc, ex);
-            il.Emit(OpCodes.Throw);
+
+            if (ReflectionHelper.ExceptionDispatchInfoCaptureMethod != null 
+                && ReflectionHelper.ExceptionDispatchInfoThrowMethod != null)
+            {
+                il.EmitCall(OpCodes.Call, ReflectionHelper.ExceptionDispatchInfoCaptureMethod, null);
+                il.EmitCall(OpCodes.Callvirt, ReflectionHelper.ExceptionDispatchInfoThrowMethod, null);
+            }
+            else
+            {
+                il.Emit(OpCodes.Throw);
+            }
 
             il.MarkLabel(noException);
 

src/Utilities/ReflectionHelper.cs

@@ -149,5 +149,21 @@ public static TAttribute[] GetAllAttributes<TAttribute>(MemberInfo member, bool
             attributes.AddRange(GetAttributes<TAttribute>(member, inherits));
             return attributes.ToArray();
         }
+
+        public static readonly MethodInfo ExceptionDispatchInfoCaptureMethod;
+
+        public static readonly MethodInfo ExceptionDispatchInfoThrowMethod;
+
+        static ReflectionHelper()
+        {
+            Assembly mscorlib = typeof(int).Assembly;
+            ExceptionDispatchInfoCaptureMethod = mscorlib
+                ?.GetType("System.Runtime.ExceptionServices.ExceptionDispatchInfo")
+                ?.GetMethod("Capture", BindingFlags.Public | BindingFlags.Static, null, new Type[] { typeof(Exception) }, null);
+
+            ExceptionDispatchInfoThrowMethod = mscorlib
+                ?.GetType("System.Runtime.ExceptionServices.ExceptionDispatchInfo")
+                ?.GetMethod("Throw", BindingFlags.Public | BindingFlags.Instance, null, new Type[] { }, null);
+        }
     }
 }

tests/InterfaceInterception/InterfaceInterceptorFixture.cs

@@ -6,6 +6,7 @@
 using System.ComponentModel;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using Microsoft.Practices.Unity.InterceptionExtension.Tests.MatchingRules;
 using Microsoft.Practices.Unity.InterceptionExtension.Tests.ObjectsUnderTest;
 using Microsoft.Practices.Unity.TestSupport;
@@ -21,6 +22,7 @@
 using Unity.Interception.PolicyInjection.Pipeline;
 using Unity.Interception.PolicyInjection.Policies;
 using Unity.Interception.Utilities;
+using Unity.Lifetime;
 
 namespace Microsoft.Practices.Unity.InterceptionExtension.Tests.InterfaceInterception
 {
@@ -1669,5 +1671,63 @@ public int CompareTo(Guid other)
                 return 0;
             }
         }
+
+        [TestMethod]
+        public void InterceptorCorrectlyRethrowsException()
+        {
+            IUnityContainer container = new UnityContainer()
+                .AddNewExtension<Interception>()
+                .RegisterType(typeof(IFoo), typeof(Foo))
+                .Configure<Interception>()
+                    .SetInterceptorFor(typeof(IFoo), new InterfaceInterceptor())
+                    .AddPolicy("AlwaysMatches")
+                    .AddMatchingRule<AlwaysMatchingRule>()
+                    .AddCallHandler<CallCountHandler>("callCount", new ContainerControlledLifetimeManager())
+                .Interception
+                .Container;
+
+            IFoo myFoo = container.Resolve<IFoo>();
+
+            try
+            {
+                myFoo.DoSomething();
+                Assert.Fail("Should have thrown");
+            }
+            catch (Exception ex)
+            {
+                CallCountHandler handler = (CallCountHandler)(container.Resolve<ICallHandler>("callCount"));
+                Assert.AreEqual(1, handler.CallCount);
+                Assert.IsInstanceOfType(ex, typeof(FooCrashedException));
+
+                var stackTrace = ex.StackTrace.Split(new string[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries);
+                Assert.IsTrue(stackTrace[0].Contains("DoSomethingLocal"), "stack trace is not full");
+            }
+        }
+
+        public interface IFoo
+        {
+            void DoSomething();
+        }
+
+        public class Foo : IFoo
+        {
+            public virtual void DoSomething()
+            {
+                DoSomethingLocal();
+            }
+
+            [MethodImpl(MethodImplOptions.NoInlining)]
+            protected void DoSomethingLocal()
+            {
+                throw new FooCrashedException("oops");
+            }
+        }
+
+        public class FooCrashedException : Exception
+        {
+            public FooCrashedException(string message) : base(message)
+            {
+            }
+        }
     }
 }

tests/VirtualMethodInterception/VirtualMethodInterceptorFixture.cs

@@ -7,11 +7,15 @@
 using System.Reflection;
 using Microsoft.Practices.Unity.TestSupport;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
+using Unity;
 using Unity.Interception;
+using Unity.Interception.ContainerIntegration;
 using Unity.Interception.Interceptors;
 using Unity.Interception.Interceptors.TypeInterceptors.VirtualMethodInterception;
 using Unity.Interception.PolicyInjection;
 using Unity.Interception.PolicyInjection.Pipeline;
+using Unity.Lifetime;
+using System.Runtime.CompilerServices;
 
 namespace Microsoft.Practices.Unity.InterceptionExtension.Tests.VirtualMethodInterceptorTests
 {
@@ -866,6 +870,64 @@ public virtual X[] Test<X>() where X : IEnumerable<U>
                 }
             }
         }
+
+        [TestMethod]
+        public void InterceptorCorrectlyRethrowsException()
+        {
+            IUnityContainer container = new UnityContainer()
+                .AddNewExtension<Interception>()
+                .RegisterType(typeof(IFoo), typeof(Foo))
+                .Configure<Interception>()
+                    .SetInterceptorFor(typeof(Foo), new VirtualMethodInterceptor())
+                    .AddPolicy("AlwaysMatches")
+                    .AddMatchingRule<AlwaysMatchingRule>()
+                    .AddCallHandler<CallCountHandler>("callCount", new ContainerControlledLifetimeManager())
+                .Interception
+                .Container;
+
+            IFoo myFoo = container.Resolve<IFoo>();
+
+            try
+            {
+                myFoo.DoSomething();
+                Assert.Fail("Should have thrown");
+            }
+            catch (Exception ex)
+            {
+                CallCountHandler handler = (CallCountHandler)(container.Resolve<ICallHandler>("callCount"));
+                Assert.AreEqual(1, handler.CallCount);
+                Assert.IsInstanceOfType(ex, typeof(FooCrashedException));
+
+                var stackTrace = ex.StackTrace.Split(new string[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries);
+                Assert.IsTrue(stackTrace[0].Contains("DoSomethingLocal"), "stack trace is not full");
+            }
+        }
+
+        public interface IFoo
+        {
+            void DoSomething();
+        }
+
+        public class Foo : IFoo
+        {
+            public virtual void DoSomething()
+            {
+                DoSomethingLocal();
+            }
+
+            [MethodImpl(MethodImplOptions.NoInlining)]
+            protected void DoSomethingLocal()
+            {
+                throw new FooCrashedException("oops");
+            }
+        }
+
+        public class FooCrashedException : Exception
+        {
+            public FooCrashedException(string message) : base(message)
+            {
+            }
+        }
     }
 
     public partial class DerivedTypeCreator