Log create customer/payment errors and exceptions handling.

Author: acoumb

src/Umbraco.Forms.Integrations.Commerce.EMerchantPay/PaymentProviderWorkflow.cs

@@ -14,6 +14,7 @@
 
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.Options;
+using Microsoft.Extensions.Logging;
 
 namespace Umbraco.Forms.Integrations.Commerce.Emerchantpay
 {
@@ -33,6 +34,8 @@ public class PaymentProviderWorkflow : WorkflowType
 
         private readonly ISettingsParser _parser;
 
+        private readonly ILogger<PaymentProviderWorkflow> _logger;
+
         #region WorkflowSettings
 
         [Core.Attributes.Setting("Amount",
@@ -84,9 +87,13 @@ public class PaymentProviderWorkflow : WorkflowType
 
         #endregion
 
-        public PaymentProviderWorkflow(IOptions<PaymentProviderSettings> paymentProviderSettings, IHttpContextAccessor httpContextAccessor,
+        public PaymentProviderWorkflow(
+            IOptions<PaymentProviderSettings> paymentProviderSettings, 
+            IHttpContextAccessor httpContextAccessor,
             ConsumerService consumerService, PaymentService paymentService, UrlHelper urlHelper,
-            IMappingService<Mapping> mappingService, ISettingsParser parser)
+            IMappingService<Mapping> mappingService, 
+            ISettingsParser parser,
+            ILogger<PaymentProviderWorkflow> logger)
 
         {
             Id = new Guid(Constants.WorkflowId);
@@ -107,12 +114,14 @@ public PaymentProviderWorkflow(IOptions<PaymentProviderSettings> paymentProvider
             _parser = parser;
 
             _paymentProviderSettings = paymentProviderSettings.Value;
+
+            _logger = logger;
         }
 
         public override WorkflowExecutionStatus Execute(WorkflowExecutionContext context)
         {
             if (!_mappingService.TryParse(CustomerDetailsMappings, out var mappings)) return WorkflowExecutionStatus.Failed;
-
+            
             var mappingBuilder = new MappingBuilder()
                 .SetValues(context.Record, mappings)
                 .Build();
@@ -124,6 +133,13 @@ public override WorkflowExecutionStatus Execute(WorkflowExecutionContext context
             var createConsumerTask = Task.Run(async () => await _consumerService.Create(consumer));
 
             var result = createConsumerTask.Result;
+            if(result.Status.Contains("error") && result.Code != Constants.ErrorCode.ConsumerExists)
+            {
+                _logger.LogError($"Failed to create consumer: {result.TechnicalMessage}.");
+
+                return WorkflowExecutionStatus.Failed;
+            }
+
             if (result.Code == Constants.ErrorCode.ConsumerExists)
             {
                 // step 1.1. Get Consumer
@@ -204,6 +220,8 @@ public override WorkflowExecutionStatus Execute(WorkflowExecutionContext context
 
             formHelper.UpdateRecordFieldValue(statusKey, "error");
 
+            _logger.LogError($"Failed to create payment: {createPaymentResult.TechnicalMessage}.");
+
             return WorkflowExecutionStatus.Failed;
         }