Property type: Vary in the same way as the owner Document Type #20751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner-document-type
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an initialization promise pattern to ensure that variesByCulture and variesBySegment properties are properly loaded before creating property type workspace routes. The key changes include:
- Added initialization promise pattern that resolves when workspace context observables complete
- Converted
createPropertyTypeWorkspaceRoutesto a private async method that awaits initialization - Added preset values for
variesByCultureandvariesBySegmentwhen creating new properties - Added cleanup of initialization promise in
disconnectedCallback
...content/content-type/workspace/views/design/content-type-design-editor-properties.element.ts
Outdated
Show resolved
Hide resolved
...content/content-type/workspace/views/design/content-type-design-editor-properties.element.ts
Outdated
Show resolved
Hide resolved
...content/content-type/workspace/views/design/content-type-design-editor-properties.element.ts
Outdated
Show resolved
Hide resolved
…rkspace/views/design/content-type-design-editor-properties.element.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
madsrasmussen
approved these changes
Nov 10, 2025
nielslyngsoe
deleted the
v17/hotfix/property-types-vary-as-owner-document-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the Property Type to vary as its owner Document Type.
This aligns with v.13 UX, and is slightly UX breaking. Hence the targeting for v.17