Skip to content

Conversation

@nhudinh0309
Copy link
Contributor

This PR removes the .skip tag from the tests that now work and updates the code to make them run correctly. It also adds appropriate comments and changes the tag to .fixme for tests that need further implementation.

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a comment

Copy link
Contributor

@andr317c andr317c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhudinh0309 nhudinh0309 enabled auto-merge (squash) November 18, 2025 10:06
@nhudinh0309 nhudinh0309 merged commit a59476a into main Nov 18, 2025
26 checks passed
@nhudinh0309 nhudinh0309 deleted the v17/QA/update-skip-tests branch November 18, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants