Commit 7f3132a
feat(angular): Updates for Angular 7
As already sketched in #423,
we are already using Angular 7 with uirouter/angular over at opf/openproject
and meanwhile in production as well, so we can safely attest that the current
version of uirouter works unchanged with even the recent Angular 7.2.2 release
with only some minor hassle during the upgrade due to the peer depedndency.
This PR tries to add the dependency and a downstream test.
I had to bump the local typescript version to ensure RxJS is being
built, without it `ngc` will output the following errors
node_modules/rxjs/internal/types.d.ts(81,74): error TS1005: ';' expected.
This is due to this issue: ReactiveX/rxjs#4511
Using the newest typescript also uncovered an issue in `uiSrefStatus.ts`.
In all downstream tests with TS < 2.8., I pinned rxjs to avoid the same
issue.1 parent 960048e commit 7f3132a
File tree
37 files changed
+26239
-12
lines changed- src/directives
- test-angular-versions
- v5
- v7
- cypress/integration
- src
- app
- lazy
- environments
- test-typescript-versions
- typescript2.3
- typescript2.4
- typescript2.5
- typescript2.6
- typescript2.7
37 files changed
+26239
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
57 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
236 | | - | |
| 236 | + | |
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
| |||
0 commit comments