Commit 6e3df14
authored
Unit tests to cover most of mig/shared/base.py (#366)
Unit tests to cover about 90% of `mig/shared/base.py` wrapping existing self-tests and adding tests for most helper functions. Uses shared `before_each` method and `testconfig` provisioning to isolate configuration between tests.
* Adds fundamental coverage of client_dir_id, get_site_base_url, mask_creds, extract_field, distinguished_name_to_user, fill_distinguished_name, fill_user, canonical_user, generate_https_urls, allow_script, canonical_user_with_peers, invisible_path, requested_page, verify_local_url, brief_list and auth_type_description.
* Cover requested_url_base with some pending TODOs in corner cases of the implementation.
* Splits out legacy self-tests as suggested in GH review explicitly wrapping it as legacy_main for simplicity.1 parent 9327dae commit 6e3df14
File tree
2 files changed
+1348
-3
lines changed- tests
2 files changed
+1348
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
951 | 951 | | |
952 | 952 | | |
953 | 953 | | |
954 | | - | |
| 954 | + | |
| 955 | + | |
955 | 956 | | |
956 | 957 | | |
957 | 958 | | |
| |||
986 | 987 | | |
987 | 988 | | |
988 | 989 | | |
989 | | - | |
| 990 | + | |
| 991 | + | |
990 | 992 | | |
991 | 993 | | |
992 | 994 | | |
| |||
1032 | 1034 | | |
1033 | 1035 | | |
1034 | 1036 | | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
0 commit comments