Skip to content

Commit 815f9ee

Browse files
committed
Correct a too greedy search & replace to local variable naming instead of global misuse
1 parent 420788c commit 815f9ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ldap_hooks/hooks.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -386,13 +386,13 @@ def get_interpolated_dynamic_attributes(logger, sources, dynamic_attributes):
386386

387387

388388
def update_spawner_attributes(spawner, spawner_attributes):
389-
for SPAWNER_ATTRIBUTE, spawner_value in spawner_attributes.items():
390-
if hasattr(spawner, SPAWNER_ATTRIBUTE):
391-
attr = getattr(spawner, SPAWNER_ATTRIBUTE)
389+
for spawner_attr, spawner_value in spawner_attributes.items():
390+
if hasattr(spawner, spawner_attr):
391+
attr = getattr(spawner, spawner_attr)
392392
if isinstance(attr, dict):
393393
attr.update(spawner_value)
394394
if isinstance(attr, list) or isinstance(attr, str):
395-
setattr(spawner, SPAWNER_ATTRIBUTE, spawner_value)
395+
setattr(spawner, spawner_attr, spawner_value)
396396

397397

398398
@gen.coroutine

0 commit comments

Comments
 (0)