Skip to content

Commit f92c282

Browse files
keremncjenkins
authored andcommitted
util-stats: full translation for BroadcastStatsReceiver
=== Problem `BroadcastStatsReceiver` hides the underlying receivers' translation mode. === Solution Just translate all metrics with `FullTranslation`. Differential Revision: https://phabricator.twitter.biz/D1220816
1 parent 9602a29 commit f92c282

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

util-stats/src/main/scala/com/twitter/finagle/stats/BroadcastStatsReceiver.scala

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ object BroadcastStatsReceiver {
2222
with DelegatingStatsReceiver {
2323
val repr: AnyRef = this
2424

25+
override def scopeTranslation: NameTranslatingStatsReceiver.Mode =
26+
NameTranslatingStatsReceiver.FullTranslation
27+
2528
def counter(metricBuilder: MetricBuilder) = new BroadcastCounter.Two(
2629
first.counter(metricBuilder),
2730
second.counter(metricBuilder)
@@ -63,6 +66,9 @@ object BroadcastStatsReceiver {
6366
private class N(srs: Seq[StatsReceiver]) extends StatsReceiver with DelegatingStatsReceiver {
6467
val repr: AnyRef = this
6568

69+
override def scopeTranslation: NameTranslatingStatsReceiver.Mode =
70+
NameTranslatingStatsReceiver.FullTranslation
71+
6672
def counter(metricBuilder: MetricBuilder) =
6773
BroadcastCounter(srs.map { _.counter(metricBuilder) })
6874

0 commit comments

Comments
 (0)