Skip to content

Commit 377b409

Browse files
committed
Added table description and removed unnecessary log statement
1 parent ea15c39 commit 377b409

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

tables/lambda_log/lambda_log_mapper.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,7 @@ func (m *LambdaLogMapper) Map(_ context.Context, a any, _ ...mappers.MapOption[*
8080
if err := s3Format.UnmarshalJSON([]byte(raw)); err == nil && !isCwLog {
8181
// if s3Format.LogGroup != nil {
8282
// if row.TpTimestamp.IsZero() {
83-
slog.Error("S3 format log", "Timestamp", *s3Format.Timestamp)
8483
t := time.UnixMilli(*s3Format.Timestamp)
85-
slog.Error("S3 format log", "Timestamp", *s3Format.Timestamp, "Time", t)
8684
if err == nil {
8785
row.Timestamp = &t
8886
}

tables/lambda_log/lambda_log_table.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ func (c *LambdaLogTable) GetSourceMetadata() ([]*table.SourceMetadata[*LambdaLog
4444
},
4545
},
4646
{
47-
// TODO: Should we keep this, as we don't have a direct way to store the logs in S3 bucket?
4847
// S3 artifact source
4948
SourceName: cloudwatch_log_group.AwsCloudwatchLogGroupSourceIdentifier,
5049
Mapper: &LambdaLogMapper{},
@@ -74,6 +73,7 @@ func (c *LambdaLogTable) EnrichRow(row *LambdaLog, sourceEnrichmentFields schema
7473
row.TpDate = row.TpTimestamp.Truncate(24 * time.Hour)
7574
}
7675

76+
// tp_index
7777
row.TpIndex = schema.DefaultIndex
7878

7979
var arnRegex = regexp.MustCompile(`arn:aws:[^,\s'"\\]+`)
@@ -94,3 +94,8 @@ func (c *LambdaLogTable) EnrichRow(row *LambdaLog, sourceEnrichmentFields schema
9494

9595
return row, nil
9696
}
97+
98+
func (c *LambdaLogTable) GetDescription() string {
99+
return "AWS Lambda logs capture detailed information about function executions, including invocation context, console output, errors, and performance metrics. This table provides a structured and queryable view of Lambda log data, enabling easier analysis, troubleshooting, and monitoring."
100+
}
101+

0 commit comments

Comments
 (0)