Merge pull request #16 from tuanle03/clr-58-create-api-feedback

[CLR-58] Create API Feedback

Author: tuanle03

app/api/web/feedbacks_api.rb

@@ -1,47 +1,95 @@
 module API
   class Web::FeedbacksAPI < Grape::API
-    resource :feedback do
+    resource :feedbacks do
       desc 'Create feedback'
       params do
-        requires :content, type: String
+        requires :content, type: String, allow_blank: false
         requires :post_id, type: Integer
       end
       post do
         authenticate_user!
-        Feedback.create!({
-          content: params[:content],
-          user_id: current_user.id,
-          post_id: params[:post_id]
-        })
+        feedback = current_user.feedbacks.new(content: params[:content], post_id: params[:post_id])
+        if feedback.save
+          status 200
+          {
+            success: true,
+            message: 'Feedback created'
+          }
+        else
+          status 400
+          {
+            success: false,
+            message: feedback.error.full_messages
+          }
+        end
       end
 
-      desc 'Get feedback'
-      get do
-        Feedback.all
+      desc 'detail of feedback'
+      params do
+        requires :id, type: Integer
+      end
+      get ':id' do
+        feedback = Feedback.find_by(id: params[:id])
+        if feedback
+          status 200
+          {
+            success: true,
+            feedback: feedback
+          }
+        else
+          status 400
+          {
+            success: false,
+            message: 'Feedback not found'
+          }
+        end
       end
 
       desc 'Delete feedback'
       params do
         requires :id, type: Integer
-        requires :user_id, type: Integer
       end
       delete ':id' do
-        Feedback.find_by(id: params[:id], user_id: params[:user_id]).destroy
+        authenticate_user!
+        feedback = current_user.feedbacks.find_by(id: params[:id])
+        return status 400 if feedback.blank?
+        if feedback.destroy
+          status 200
+          {
+            success: true,
+            message: 'Feedback deleted'
+          }
+        else
+          status 400
+          {
+            success: false,
+            message: 'Feedback not found'
+          }
+        end
       end
 
       desc 'Update feedback'
       params do
         requires :id, type: Integer
-        requires :content, type: String
-        requires :user_id, type: Integer
+        requires :new_content, type: String, allow_blank: false
       end
-
       put ':id' do
-        feedback = Feedback.find_by(id: params[:id], user_id: params[:user_id])
-        feedback.update!({
-          content: params[:content],
-          user_id: params[:user_id]
-        })
+        authenticate_user!
+        feedback = current_user.feedbacks.find_by(id: params[:id])
+        feedback.update(content: params[:new_content])
+        if feedback.save
+          status 200
+          {
+            success: true,
+            message: 'Feedback updated'
+          }
+        else
+          status 400
+          {
+            success: false,
+            message: 'Feedback can not update'
+          }
+        end
       end
     end
   end

app/models/user.rb

@@ -7,6 +7,9 @@ class User < ApplicationRecord
     :recoverable, :rememberable, :validatable,
     :jwt_authenticatable, jwt_revocation_strategy: self
 
+  has_many :posts, dependent: :destroy
+  has_many :feedbacks, dependent: :destroy
+
   def generate_jwt
     payload = { user_id: id, exp: 1.day.from_now.to_i }
     JWT.encode(payload, Rails.application.credentials.devise_jwt_secret_key)

spec/api/web/feedbacks_api_spec.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+require 'rack/test'
+
+describe Web do
+  include Rack::Test::Methods
+
+  def app
+    Web::FeedbacksAPI
+  end
+
+  let(:user) { create(:user) }
+  let(:token) { user.generate_jwt }
+
+  describe 'POST /web/feedbacks' do
+    context 'with valid parameters' do
+      it 'creates a feedback' do
+        post '/web/feedbacks', { content: 'Great post!', post_id: 1 }, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(200)
+        json = JSON.parse(last_response.body)
+        expect(json['success']).to eq(true)
+        expect(json['message']).to eq('Feedback created')
+      end
+    end
+
+    context 'with invalid parameters' do
+      it 'returns an error message' do
+        post '/web/feedbacks', { content: '', post_id: 1 }, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(400)
+      end
+    end
+  end
+
+  describe 'GET /web/feedbacks/:id' do
+    let(:feedback) { create(:feedback, user_id: user.id) }
+
+    context 'with a valid feedback ID' do
+      it 'returns the details of the feedback' do
+        get "/web/feedbacks/#{feedback.id}", {}, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(200)
+        json = JSON.parse(last_response.body)
+        expect(json['success']).to eq(true)
+        expect(json['feedback']['id']).to eq(feedback.id)
+      end
+    end
+
+    context 'with an invalid feedback ID' do
+      it 'returns an error message' do
+        get '/web/feedbacks/999', {}, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(400)
+        json = JSON.parse(last_response.body)
+        expect(json['success']).to eq(false)
+        expect(json['message']).to eq('Feedback not found')
+      end
+    end
+  end
+
+  describe 'DELETE /web/feedbacks/:id' do
+    let(:feedback) { create(:feedback, user: user) }
+
+    context 'with a valid feedback ID' do
+      it 'deletes the feedback' do
+        delete "/web/feedbacks/#{feedback.id}", {}, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(200)
+        json = JSON.parse(last_response.body)
+        expect(json['success']).to eq(true)
+        expect(json['message']).to eq('Feedback deleted')
+      end
+    end
+
+    context 'with an invalid feedback ID' do
+      it 'returns an error message' do
+        delete '/web/feedbacks/999', {}, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(400)
+      end
+    end
+  end
+
+  describe 'PUT /web/feedbacks/:id' do
+    let(:feedback) { create(:feedback, user: user) }
+
+    context 'with valid parameters' do
+      it 'updates the feedback' do
+        put "/web/feedbacks/#{feedback.id}", { new_content: 'Updated content' }, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(200)
+        json = JSON.parse(last_response.body)
+        expect(json['success']).to eq(true)
+        expect(json['message']).to eq('Feedback updated')
+      end
+    end
+
+    context 'with invalid parameters' do
+      it 'returns an error message' do
+        put "/web/feedbacks/#{feedback.id}", { new_content: '' }, 'HTTP_AUTHORIZATION' => "Bearer #{token}"
+
+        expect(last_response.status).to eq(400)
+      end
+    end
+  end
+end