From 6a91d3f57c851d7778b50252daa3b599ad5a4fa9 Mon Sep 17 00:00:00 2001 From: Dominik Biedebach Date: Tue, 3 Dec 2024 08:42:50 +0100 Subject: [PATCH] chore: use biome instead of eslint for linting --- .github/renovate.json5 | 3 +-- .github/workflows/ci.yml | 2 +- .vscode/extensions.json | 2 +- .vscode/settings.json | 34 ++++------------------------------ package.json | 12 +++++++----- packages/core/package.json | 2 -- 6 files changed, 14 insertions(+), 41 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index c93ab6b..8716add 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -39,8 +39,7 @@ { "groupName": "lint", "matchPackageNames": [ - "@antfu/eslint-config", - "eslint", + "@biomejs/biome", "prettier" ] }, diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7f5094a..dad8224 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,7 +35,7 @@ jobs: run: pnpm -r lint - name: 📝 Check format - run: pnpm format:check + run: pnpm format - name: 💪 Type check run: pnpm -r test:typecheck diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 8a09943..583bad1 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -1,3 +1,3 @@ { - "recommendations": ["dbaeumer.vscode-eslint"] + "recommendations": ["biomejs.biome"] } diff --git a/.vscode/settings.json b/.vscode/settings.json index 29d8589..a45d6d0 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -1,9 +1,10 @@ { - "editor.defaultFormatter": "dbaeumer.vscode-eslint", + "biome.enabled": true, + "editor.defaultFormatter": "biomejs.biome", // Disable the default formatter, use eslint instead "prettier.enable": false, - "editor.formatOnSave": false, + "editor.formatOnSave": true, // Auto fix "editor.codeActionsOnSave": { @@ -11,32 +12,5 @@ "source.organizeImports": "never", "source.fixAll.biome": "explicit", "source.organizeImports.biome": "explicit" - }, - - // Silent the stylistic rules in you IDE, but still auto fix them - "eslint.rules.customizations": [ - { "rule": "style/*", "severity": "off" }, - { "rule": "*-indent", "severity": "off" }, - { "rule": "*-spacing", "severity": "off" }, - { "rule": "*-spaces", "severity": "off" }, - { "rule": "*-order", "severity": "off" }, - { "rule": "*-dangle", "severity": "off" }, - { "rule": "*-newline", "severity": "off" }, - { "rule": "*quotes", "severity": "off" }, - { "rule": "*semi", "severity": "off" } - ], - - // Enable eslint for all supported languages - "eslint.validate": [ - "javascript", - "javascriptreact", - "typescript", - "typescriptreact", - "vue", - "html", - "markdown", - "json", - "jsonc", - "yaml" - ] + } } diff --git a/package.json b/package.json index 08a59c8..c7a6d92 100644 --- a/package.json +++ b/package.json @@ -15,10 +15,12 @@ "docs:dev": "pnpm run --filter @tsky/docs dev", "docs:build": "pnpm run --filter @tsky/docs build", "docs:preview": "pnpm run --filter @tsky/docs preview", - "format": "biome check --write .", - "format:check": "biome check", - "lint": "eslint ./packages ./docs", - "lint:fix": "eslint . --fix" + "format": "biome format", + "format:fix": "biome format --write .", + "lint": "biome lint .", + "lint:fix": "biome lint --write .", + "check": "biome check", + "check:fix": "biome check --write ." }, "devDependencies": { "@antfu/eslint-config": "^3.11.2", @@ -32,6 +34,6 @@ "typescript-eslint": "^8.16.0" }, "nano-staged": { - "*.{js,ts,cjs,mjs}": ["biome check --write --"] + "*.{js,ts,cjs,mjs,json}": ["biome check --write --"] } } diff --git a/packages/core/package.json b/packages/core/package.json index 24c4dc3..6ed0fed 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -24,8 +24,6 @@ "files": ["dist"], "scripts": { "build": "pkgroll", - "lint": "eslint ./src", - "lint:fix": "eslint ./src --fix", "test": "vitest", "test:typescript": "tsc --noEmit" },