feat(tvm): remove deprecated config in TIP-6780 implementation (#6448)

* feat(tvm): remove allowtvmselfdestructRestriction from commonParameter

* feat(test): remove test for allowtvmselfdestructRestriction commonParameter

* feat(tvm): remove constant COMMITTEE_ALLOW_TVM_SELFDESTRUCT_RESTRICTION

Author: aiden3885

chainbase/src/main/java/org/tron/core/store/DynamicPropertiesStore.java

@@ -2957,7 +2957,7 @@ public long getAllowTvmSelfdestructRestriction() {
     return Optional.ofNullable(getUnchecked(ALLOW_TVM_SELFDESTRUCT_RESTRICTION))
         .map(BytesCapsule::getData)
         .map(ByteArray::toLong)
-        .orElse(CommonParameter.getInstance().getAllowTvmSelfdestructRestriction());
+        .orElse(0L);
   }
 
   public void saveAllowTvmSelfdestructRestriction(long value) {

common/src/main/java/org/tron/common/parameter/CommonParameter.java

@@ -750,10 +750,6 @@ public class CommonParameter {
   @Setter
   public long allowTvmBlob;
 
-  @Getter
-  @Setter
-  public long allowTvmSelfdestructRestriction;
-
   private static double calcMaxTimeRatio() {
     //return max(2.0, min(5.0, 5 * 4.0 / max(Runtime.getRuntime().availableProcessors(), 1)));
     return 5.0;

common/src/main/java/org/tron/core/Constant.java

@@ -421,9 +421,6 @@ public class Constant {
 
   public static final String COMMITTEE_ALLOW_TVM_BLOB = "committee.allowTvmBlob";
 
-  public static final String COMMITTEE_ALLOW_TVM_SELFDESTRUCT_RESTRICTION =
-      "committee.allowTvmSelfdestructRestriction";
-
   public static final String COMMITTEE_PROPOSAL_EXPIRE_TIME = "committee.proposalExpireTime";
 
 }

framework/src/main/java/org/tron/core/config/args/Args.java

@@ -250,7 +250,6 @@ public static void clearParam() {
     PARAMETER.consensusLogicOptimization = 0;
     PARAMETER.allowTvmCancun = 0;
     PARAMETER.allowTvmBlob = 0;
-    PARAMETER.allowTvmSelfdestructRestriction = 0;
     PARAMETER.rpcMaxRstStream = 0;
     PARAMETER.rpcSecondsPerWindow = 0;
   }
@@ -1272,10 +1271,6 @@ public static void setParam(final Config config) {
         config.hasPath(Constant.COMMITTEE_ALLOW_TVM_BLOB) ? config
             .getInt(Constant.COMMITTEE_ALLOW_TVM_BLOB) : 0;
 
-    PARAMETER.allowTvmSelfdestructRestriction =
-        config.hasPath(Constant.COMMITTEE_ALLOW_TVM_SELFDESTRUCT_RESTRICTION) ? config
-            .getInt(Constant.COMMITTEE_ALLOW_TVM_SELFDESTRUCT_RESTRICTION) : 0;
-
     logConfig();
   }
 

framework/src/test/java/org/tron/common/ParameterTest.java

@@ -322,7 +322,5 @@ public void testCommonParameter() {
     assertEquals(1, parameter.getAllowEnergyAdjustment());
     parameter.setMaxCreateAccountTxSize(1000);
     assertEquals(1000, parameter.getMaxCreateAccountTxSize());
-    parameter.setAllowTvmSelfdestructRestriction(1);
-    assertEquals(1, parameter.getAllowTvmSelfdestructRestriction());
   }
 }