Skip to content

Commit f06e723

Browse files
committed
chore(observability-map): declare the ES2020 lib the tests already need
The tests call String.prototype.matchAll, an ES2020 library feature, while `lib` said ES2019. Typecheck passed anyway because @types/node v24 declares `/// <reference lib="es2020" />`, so the program already contained es2020. No behaviour changes; the declaration now states the requirement instead of resting on a transitive reference.
1 parent 32c301d commit f06e723

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

internal-packages/observability-map/tsconfig.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
{
22
"compilerOptions": {
33
"target": "ES2019",
4-
"lib": ["ES2019"],
4+
// ES2020 rather than the ES2019 most sibling packages use, because the tests call
5+
// String.prototype.matchAll. It already resolved: @types/node carries a
6+
// `/// <reference lib="es2020" />`, so the program had es2020 whatever this line said. Stating
7+
// it here stops the requirement resting on a transitive reference from a types package.
8+
"lib": ["ES2020"],
59
"module": "ESNext",
610
"moduleResolution": "Bundler",
711
"esModuleInterop": true,

0 commit comments

Comments
 (0)