Skip to content

Commit dc97f47

Browse files
committed
fix(webapp): let the webhook deliveries table scroll
The deliveries list passed stickyHeader, which switches the table container to overflow-visible and so stops it being the scroll container. Every other list in the app (runs, sessions, batches) leaves it off and renders the table directly in the layout's content row. The header stays sticky regardless, because TableHeader always sets sticky top-0.
1 parent ca9d4a3 commit dc97f47

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks._index

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.webhooks._index/route.tsx

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -166,14 +166,11 @@ export default function Page() {
166166
<ListPagination list={{ pagination }} />
167167
</div>
168168
</div>
169-
<div className="min-h-0 overflow-hidden">
170-
<DeliveriesTable
171-
deliveries={visibleDeliveries}
172-
showWebhook
173-
stickyHeader
174-
hasFilters={hasFilters}
175-
/>
176-
</div>
169+
{/* Sits directly in the 1fr row, like the runs, sessions and batches lists. No
170+
stickyHeader: that switches Table's container to overflow-visible, which stops it
171+
being the scroll container. The header is sticky either way (TableHeader always sets
172+
sticky top-0), and the other webhook tables only pass it because an ancestor scrolls. */}
173+
<DeliveriesTable deliveries={visibleDeliveries} showWebhook hasFilters={hasFilters} />
177174
</div>
178175
</PageBody>
179176
</>

0 commit comments

Comments
 (0)