close the controller when signal aborts

ericallam · ericallam · commit b5db525bb252 · 2025-11-11T14:12:37.000Z
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -181,7 +181,7 @@
     "@opentelemetry/sdk-trace-base": "2.0.1",
     "@opentelemetry/sdk-trace-node": "2.0.1",
     "@opentelemetry/semantic-conventions": "1.36.0",
-    "@s2-dev/streamstore": "0.17.1",
+    "@s2-dev/streamstore": "0.17.3",
     "dequal": "^2.0.3",
     "eventsource": "^3.0.5",
     "eventsource-parser": "^3.0.0",
diff --git a/packages/core/src/v3/realtimeStreams/streamInstance.ts b/packages/core/src/v3/realtimeStreams/streamInstance.ts
@@ -77,6 +77,7 @@ export class StreamInstance<T> implements StreamsWriter {
 
         while (true) {
           if (self.options.signal?.aborted) {
+            controller.close();
             break;
           }
 
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/references/realtime-streams/src/trigger/streams.ts b/references/realtime-streams/src/trigger/streams.ts
@@ -569,7 +569,7 @@ const streamWriterTesterTask = task({
 
     const chunks = [];
 
-    for await (const chunk of await streams.read(ctx.run.id, { timeoutInSeconds: 5 })) {
+    for await (const chunk of await streams.read<string>(ctx.run.id, { timeoutInSeconds: 5 })) {
       chunks.push(chunk);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,7 @@ export class StreamInstance<T> implements StreamsWriter {`
`77`	`77`
`78`	`78`	`while (true) {`
`79`	`79`	`if (self.options.signal?.aborted) {`
	`80`	`+ controller.close();`
`80`	`81`	`break;`
`81`	`82`	`}`
`82`	`83`
Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ const streamWriterTesterTask = task({`
`569`	`569`
`570`	`570`	`const chunks = [];`
`571`	`571`
`572`		`- for await (const chunk of await streams.read(ctx.run.id, { timeoutInSeconds: 5 })) {`
	`572`	`+ for await (const chunk of await streams.read<string>(ctx.run.id, { timeoutInSeconds: 5 })) {`
`573`	`573`	`chunks.push(chunk);`
`574`	`574`	`}`
`575`	`575`