fix(clickhouse): make the patched rawMessage non-enumerable at the source

Making the field non-enumerable only on InsertError left the leak open one
layer down: the client logs the raw ClickHouseError at every insert-error site
before converting it, and the patch assigned rawMessage as a plain enumerable
property, so the offending-row snippet still reached structured logs. The patch
now defines the field non-enumerable itself.

Covers the patch's behaviour with a test that reads the row hint back through
the public parseError export, which also fails loudly if the patch ever stops
being applied.

Author: ericallam

internal-packages/clickhouse/src/client/errors.test.ts

@@ -1,10 +1,28 @@
+import { ClickHouseError, parseError } from "@clickhouse/client";
 import { describe, expect, it } from "vitest";
 import { InsertError } from "./errors.js";
 
-describe("InsertError.rawMessage", () => {
-  const rawMessage =
-    'Code: 117. DB::Exception: Cannot parse JSON object here: {"secret":"customer-payload"}: (at row 3)';
+const rawMessage =
+  'Code: 117. DB::Exception: Cannot parse JSON object here: {"secret":"customer-payload"}: (at row 3) (INCORRECT_DATA) (version 26.2.1.1)';
+
+describe("patched ClickHouseError.rawMessage", () => {
+  it("carries the untruncated text so the recovery path can read the row hint", () => {
+    const error = parseError(rawMessage);
+
+    expect(error).toBeInstanceOf(ClickHouseError);
+    expect((error as ClickHouseError).rawMessage).toContain("at row 3");
+  });
 
+  it("stays out of anything that serializes own enumerable properties", () => {
+    const error = parseError(rawMessage);
+
+    expect(Object.keys(error)).not.toContain("rawMessage");
+    expect(JSON.stringify(error)).not.toContain("customer-payload");
+    expect(JSON.stringify({ ...error })).not.toContain("customer-payload");
+  });
+});
+
+describe("InsertError.rawMessage", () => {
   it("is readable by the recovery path", () => {
     expect(new InsertError("Cannot parse JSON object here", { rawMessage }).rawMessage).toBe(
       rawMessage

patches/@clickhouse__client-common@1.12.1.patch

@@ -21,7 +21,7 @@ index e06fa4ab36537c2a448857c1b001e70cd771bfe5..9750bd7e1285ac8cf2c8095b592ed344
 -        return new ClickHouseError(groups);
 +        const error = new ClickHouseError(groups);
 +        if (!inputIsError && groups.message.startsWith("Cannot parse JSON object")) {
-+            error.rawMessage = message;
++            Object.defineProperty(error, "rawMessage", { value: message, enumerable: false });
 +        }
 +        return error;
      }