fix(webapp): keep agent-suggested threshold and window in query alert prefill

Query alerts suggested by the dashboard agent now open with the
suggested threshold and time window prefilled.

Mono-RevId: 9a125338c2eddb048059949b2161432590941234

Author: kathiekiwi

.server-changes/query-alert-agent-prefill-threshold.md

@@ -0,0 +1,6 @@
+---
+area: webapp
+type: fix
+---
+
+Fix the dashboard agent's suggested threshold and window being dropped when it prefills a query alert.

apps/webapp/app/components/alerts/QueryAlertTranscript.dom.test.ts

@@ -333,6 +333,19 @@ describe("QueryAlertTranscript", () => {
     choose("For 24 hours");
   }
 
+  it("keeps the agent-suggested threshold and window", async () => {
+    await mount({ operator: ">", value: 42, windowSec: 601 });
+    choose("Continue");
+    choose("Value crosses a threshold");
+    expect(input("Threshold").value).toBe("42");
+    expect(row("Above").querySelector('[aria-label="Selected"]')).not.toBeNull();
+    expect(
+      document.querySelector<HTMLButtonElement>('button[aria-label="Next question"]')!.disabled
+    ).toBe(false);
+    choose("Above");
+    expect(input("Window").value).toBe("11");
+  });
+
   it("offers This chat in the agent, preselected, and sends the chat ids", async () => {
     const release = vi.fn();
     await mount({}, { chatId: "chat_on_use", ensure: async () => ({ chatId: "chat_1", release }) });

apps/webapp/app/components/alerts/QueryAlertTranscript.tsx

@@ -39,6 +39,8 @@ export type QueryWatchPrefill = {
   mode?: QueryAlertMode;
   measure?: string;
   operator?: ">" | "<";
+  value?: number;
+  windowSec?: number;
 };
 
 export function queryWatchPrefill(
@@ -105,6 +107,8 @@ export function QueryAlertTranscript({
           mode: prefill.mode,
           measure: prefill.measure,
           operator: prefill.operator,
+          value: prefill.value,
+          windowSec: prefill.windowSec,
           ...analyzed,
         }
       : undefined;

apps/webapp/app/components/alerts/queryAlertLink.ts

@@ -18,6 +18,8 @@ export type QueryAlertPrefill = {
   mode?: QueryAlertMode;
   measure?: string;
   operator?: ">" | "<";
+  value?: number;
+  windowSec?: number;
 };
 
 export function queryAlertNameKey(mode: QueryAlertMode, measure?: string) {

apps/webapp/app/components/alerts/useQueryAlertDraft.ts

@@ -56,13 +56,19 @@ export function useQueryAlertDraft(
   const measure = mode === "match" ? undefined : signal.measure;
 
   const [operator, setOperator] = useState<">" | "<">(prefill.operator ?? ">");
-  const [valueText, setValueText] = useState("");
+  const [valueText, setValueText] = useState(() =>
+    typeof prefill.value === "number" && Number.isFinite(prefill.value) ? String(prefill.value) : ""
+  );
   const value = valueText.trim() === "" ? undefined : Number(valueText);
   const valueValid = mode !== "threshold" || (value !== undefined && Number.isFinite(value));
 
   const bounds = queryWindowBounds(analysis.limits);
   const defaultWindow = defaultQueryWindowMinutes(prefill.period, analysis.limits);
-  const [windowText, setWindowText] = useState(() => String(defaultWindow));
+  const [windowText, setWindowText] = useState(() => {
+    const windowSec = prefill.windowSec;
+    if (typeof windowSec !== "number" || !Number.isFinite(windowSec)) return String(defaultWindow);
+    return String(Math.min(bounds.max, Math.max(bounds.min, Math.ceil(windowSec / 60))));
+  });
   const windowMinutes = mode === "match" ? defaultWindow : Number(windowText);
   const windowValid =
     mode === "match" ||

apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.test.ts

@@ -13,6 +13,7 @@ import {
   alertDraftPatchSchema,
   applyDraftPatch,
   errorGroupToResolve,
+  queryWatchFromPatch,
   type AlertDraftPatch,
 } from "./draftPatch";
 import { draftResultLines } from "./useCreationAgentSend";
@@ -267,6 +268,17 @@ describe("below-threshold operator", () => {
   });
 });
 
+describe("queryWatchFromPatch", () => {
+  it("carries the threshold value and window", () => {
+    const patch = {
+      area: "query",
+      query: "SELECT 1",
+      condition: { operator: ">", value: 42, windowSec: 601 },
+    } as AlertDraftPatch;
+    expect(queryWatchFromPatch(patch)).toMatchObject({ operator: ">", value: 42, windowSec: 601 });
+  });
+});
+
 describe("unknown-key rejection", () => {
   it("fails when a patch with an unknown key is applied client-side without rejection", () => {
     const result = alertDraftPatchSchema.safeParse({

apps/webapp/app/components/dashboard-agent/alert-creation/draftPatch.ts

@@ -67,6 +67,8 @@ export function queryWatchFromPatch(patch: AlertDraftPatch): QueryWatchPrefill |
     mode: patch.querySignalChoice?.mode,
     measure: patch.querySignalChoice?.measure,
     operator: patch.condition?.operator,
+    value: patch.condition?.value,
+    windowSec: patch.condition?.windowSec,
   };
 }