Skip to content

Commit 2e01a49

Browse files
committed
fix(webapp): primary popover trigger keeps white ink on the light theme
1 parent b9033f3 commit 2e01a49

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

  • apps/webapp/app
    • components/primitives
    • routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint

apps/webapp/app/components/primitives/Popover.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,12 @@ const popoverArrowTriggerVariants = {
212212
icon: "text-text-dimmed group-hover:text-text-bright",
213213
},
214214
primary: {
215+
// White ink, not text-bright: indigo is theme-stable, and text-bright flips
216+
// dark on the light theme.
215217
trigger:
216-
"bg-indigo-600 border border-indigo-500 text-text-bright hover:bg-indigo-500 hover:border-indigo-400 disabled:opacity-50 disabled:pointer-events-none",
217-
text: "text-text-bright hover:text-white",
218-
icon: "text-text-bright",
218+
"bg-indigo-600 border border-indigo-500 text-white hover:bg-indigo-500 hover:border-indigo-400 disabled:opacity-50 disabled:pointer-events-none",
219+
text: "text-white",
220+
icon: "text-white",
219221
},
220222
secondary: {
221223
trigger:

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.errors.$fingerprint/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,7 @@ function ErrorStatusDropdown({
830830
<>
831831
<Popover open={popoverOpen} onOpenChange={setPopoverOpen}>
832832
<PopoverArrowTrigger variant="primary" disabled={isSubmitting} className="items-center">
833-
<IconCircleDotted className="-ml-1 mr-1 size-3.5 text-text-bright" />
833+
<IconCircleDotted className="-ml-1 mr-1 size-3.5 text-white" />
834834
Mark error as…
835835
</PopoverArrowTrigger>
836836
<PopoverContent className="inline-flex min-w-0! flex-col p-1" align="end">

0 commit comments

Comments
 (0)