fix: Correct argument names and simplify tests

Author: tomasfarias

airflow_dbt_python/hooks/s3.py

@@ -1,4 +1,5 @@
 """Provides an S3 hook exclusively for fetching dbt files."""
+from __future__ import annotations
 
 from pathlib import Path
 from typing import Optional

airflow_dbt_python/operators/dbt.py

@@ -115,7 +115,7 @@ def __init__(
         self.use_colors = use_colors
         self.no_use_colors = no_use_colors
         self.no_version_check = no_version_check
-        self.defer = defer
+        self.dbt_defer = defer
         self.no_defer = no_defer
         self.single_threaded = single_threaded
         self.record_timing_info = record_timing_info

tests/hooks/s3/test_dbt_s3_hook.py

@@ -1,6 +1,6 @@
 """Unit test module for DbtS3Hook."""
 import io
-import os
+from pathlib import Path
 from zipfile import ZipFile
 
 import pytest
@@ -167,25 +167,34 @@ def test_get_dbt_project_no_trailing_slash(s3_bucket, tmpdir, dbt_project_file):
     assert result == "col1,col2\n1,2"
 
 
-def test_get_dbt_project_from_zip_file(s3_bucket, tmpdir, dbt_project_file):
-    """Test pulling dbt project from ZipFile in S3 path."""
-    with open(dbt_project_file) as pf:
-        project_content = pf.read()
-
-    with open("data/a_seed.csv", "w+") as f:
+@pytest.fixture
+def test_files():
+    f1 = Path("data/a_seed.csv")
+    with open(f1, "w+") as f:
         f.write("col1,col2\n1,2")
 
-    with open("models/a_model.sql", "w+") as f:
+    f2 = Path("models/a_model.sql")
+    with open(f2, "w+") as f:
         f.write("SELECT 1")
-    with open("models/another_model.sql", "w+") as f:
+    f3 = Path("models/another_model.sql")
+    with open(f3, "w+") as f:
         f.write("SELECT 2")
+    yield [f1, f2, f3]
+    f1.unlink()
+    f2.unlink()
+    f3.unlink()
+
+
+def test_get_dbt_project_from_zip_file(s3_bucket, tmpdir, dbt_project_file, test_files):
+    """Test pulling dbt project from ZipFile in S3 path."""
+    with open(dbt_project_file) as pf:
+        project_content = pf.read()
 
     zip_buffer = io.BytesIO()
     with ZipFile(zip_buffer, "a") as zf:
         zf.write(dbt_project_file, "dbt_project.yml")
-        zf.write("data/a_seed.csv")
-        zf.write("models/a_model.sql")
-        zf.write("models/another_model.sql")
+        for f in test_files:
+            zf.write(f)
 
     hook = DbtS3Hook()
     bucket = hook.get_bucket(s3_bucket)