fix: Don't fail on directory cleanup

Author: tomasfarias

airflow_dbt_python/hooks/dbt.py

@@ -293,7 +293,11 @@ def dbt_directory(
         store_project_dir = config.project_dir
 
         with update_environment(env_vars):
-            with TemporaryDirectory(prefix="airflow_tmp") as tmp_dir:
+            with TemporaryDirectory(
+                # Cleanup things on a best-effort basis
+                prefix="airflow_tmp",
+                ignore_cleanup_errors=True,
+            ) as tmp_dir:
                 self.log.info("Initializing temporary directory: %s", tmp_dir)
 
                 try:
@@ -549,5 +553,5 @@ class DbtSnowflakeHook(DbtHook):
         "connect_retries",
         "connect_timeout",
         "retry_on_database_errors",
-        "retry_on_database_errors",
+        "retry_all",
     ]

tests/hooks/dbt/test_dbt_hook_base.py

@@ -89,22 +89,28 @@ def download_dbt_project(self, *args, **kwargs):
 
 
 def test_dbt_hook_download_dbt_profiles():
-    """Test dbt hook calls remote correctly."""
+    """Test dbt hook calls remote correctly.
+
+    We ignore types as we are monkey patching a FakeRemote for testing.
+    """
     hook = DbtHook()
-    hook.remotes[("", None)] = FakeRemote()
+    hook.remotes[("", None)] = FakeRemote()  # type: ignore
 
-    args, kwargs = hook.download_dbt_profiles("/path/to/profiles", "/path/to/store")
+    args, kwargs = hook.download_dbt_profiles("/path/to/profiles", "/path/to/store")  # type: ignore
 
     assert args == ("/path/to/profiles", "/path/to/store")
     assert kwargs == {}
 
 
 def test_dbt_hook_upload_dbt_project():
-    """Test dbt hook calls remote correctly."""
+    """Test dbt hook calls remote correctly.
+
+    We ignore types as we are monkey patching a FakeRemote for testing.
+    """
     hook = DbtHook()
-    hook.remotes[("", None)] = FakeRemote()
+    hook.remotes[("", None)] = FakeRemote()  # type: ignore
 
-    args, kwargs = hook.upload_dbt_project(
+    args, kwargs = hook.upload_dbt_project(  # type: ignore
         "/path/to/profiles", "/path/to/store", replace=True, delete_before=True
     )
 
@@ -115,9 +121,9 @@ def test_dbt_hook_upload_dbt_project():
 def test_dbt_hook_download_dbt_project():
     """Test dbt hook calls remote correctly."""
     hook = DbtHook(project_conn_id="conn_id")
-    hook.remotes[("", "conn_id")] = FakeRemote()
+    hook.remotes[("", "conn_id")] = FakeRemote()  # type: ignore
 
-    args, kwargs = hook.download_dbt_project("/path/to/profiles", "/path/to/store")
+    args, kwargs = hook.download_dbt_project("/path/to/profiles", "/path/to/store")  # type: ignore
 
     assert args == ("/path/to/profiles", "/path/to/store")
     assert kwargs == {}