Skip to content

Commit ded937e

Browse files
authored
Docstring fixes (#997)
2 parents 712eee1 + 0f44024 commit ded937e

File tree

7 files changed

+44
-12
lines changed

7 files changed

+44
-12
lines changed

CHANGES

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,21 @@ $ pipx install --suffix=@next 'tmuxp' --pip-args '\--pre' --force
3131

3232
<!-- To maintainers and contributors: Please add notes for the forthcoming version below -->
3333

34-
_Future release notes will be placed here_
34+
_Upcoming changes will be written here._
35+
36+
### Documentation (#997)
37+
38+
Sphinx build warnings fixed:
39+
40+
- `docs/conf.py`: Add sphinx-autodoc-typehints configuration
41+
(`always_document_param_types`, `typehints_use_rtype`) and suppress
42+
forward reference warnings from TYPE_CHECKING blocks
43+
- `src/tmuxp/workspace/builder.py`: Fix "via via" typo in docstring
44+
- `src/tmuxp/workspace/freezer.py`: Fix "workspacee" typo in docstring
45+
- `src/tmuxp/log.py`: Fix RST parameter formatting in docstrings
46+
- `src/tmuxp/workspace/finders.py`: Add missing Returns/Raises sections
47+
to `find_workspace_file` docstring
48+
- `docs/about_tmux.md`: Fix orphan footnote reference
3549

3650
## tmuxp 1.59.0 (2025-11-30)
3751

docs/about_tmux.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,7 +572,7 @@ line. The interval is determined by the `status-interval`:
572572
| `C-Up, C-Down` `C-Left, C-Right` | Resize the current pane in steps of one cell. |
573573
| `M-Up, M-Down` `M-Left, M-Right` | Resize the current pane in steps of five cells. |
574574

575-
Source: tmux manpage[1].
575+
Source: tmux manpage[^id2].
576576

577577
To get the text documentation of a `.1` manual file:
578578

docs/conf.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,16 @@
119119
"member-order": "bysource",
120120
}
121121

122+
# sphinx-autodoc-typehints
123+
always_document_param_types = True
124+
typehints_use_rtype = False
125+
126+
# Suppress warnings for forward references that can't be resolved
127+
# (types in TYPE_CHECKING blocks used for circular import avoidance)
128+
suppress_warnings = [
129+
"sphinx_autodoc_typehints.forward_reference",
130+
]
131+
122132
# sphinxext.opengraph
123133
ogp_site_url = about["__docs__"]
124134
ogp_image = "_static/img/icons/icon-192x192.png"

src/tmuxp/log.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,14 +76,13 @@ def template(
7676
7777
Parameters
7878
----------
79-
:py:class:`logging.LogRecord` :
80-
object. this is passed in from inside the
81-
:py:meth:`logging.Formatter.format` record.
79+
record : :py:class:`logging.LogRecord`
80+
Object passed from :py:meth:`logging.Formatter.format`.
8281
8382
Returns
8483
-------
8584
str
86-
template for logger message
85+
Template for logger message.
8786
"""
8887
reset = Style.RESET_ALL
8988
levelname = set_style(
@@ -147,9 +146,8 @@ def debug_log_template(
147146
148147
Parameters
149148
----------
150-
record : :py:class:`logging.LogRecord`
151-
This is passed in from inside the :py:meth:`logging.Formatter.format`
152-
record.
149+
record : :py:class:`logging.LogRecord`
150+
Object passed from :py:meth:`logging.Formatter.format`.
153151
154152
Returns
155153
-------

src/tmuxp/workspace/builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class WorkspaceBuilder:
110110
111111
The normal phase of loading is:
112112
113-
1. Load JSON / YAML file via via :class:`pathlib.Path`::
113+
1. Load JSON / YAML file via :class:`pathlib.Path`::
114114
115115
from tmuxp._internal import config_reader
116116
session_config = config_reader.ConfigReader._load(raw_yaml)

src/tmuxp/workspace/finders.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,21 @@ def find_workspace_file(
153153
Parameters
154154
----------
155155
workspace_file : str
156-
workspace file, valid examples:
156+
Workspace file, valid examples:
157157
158158
- a file name, my_workspace.yaml
159159
- relative path, ../my_workspace.yaml or ../project
160160
- a period, .
161+
162+
Returns
163+
-------
164+
str
165+
Resolved absolute path to workspace file.
166+
167+
Raises
168+
------
169+
FileNotFoundError
170+
If workspace file cannot be found.
161171
"""
162172
if not workspace_dir:
163173
workspace_dir = get_workspace_dir()

src/tmuxp/workspace/freezer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def inline(workspace_dict: dict[str, t.Any]) -> t.Any:
5252

5353

5454
def freeze(session: Session) -> dict[str, t.Any]:
55-
"""Freeze live tmux session into a tmuxp workspacee.
55+
"""Freeze live tmux session into a tmuxp workspace.
5656
5757
Parameters
5858
----------

0 commit comments

Comments
 (0)