tests/test_window.py(refactor): Remove pre-3.2 version conditionals

why: tmux >= 3.2a is now required, version conditionals are unnecessary.
what:
- Simplify test_split_shell pane_start_command check - always quote format
- Simplify test_split_size - always use modern -l flag
- Simplify test_set_show_window_options - pane-border-format always available
- Simplify test_show_window_option_unknown - always expect InvalidOption
- Simplify test_set_window_option_invalid - always expect InvalidOption
- Remove skip from test_empty_window_name - filter flag always available
- Remove skip from test_split_with_environment - -e flag always available
- Remove skip from test_split_window_zoom - -Z flag always available
- Delete test_split_with_environment_logs_warning_for_old_tmux (dead code)
- Remove skip from test_resize - resize-window always available
- Remove skip from test_new_window_with_direction - direction flags always work
- Delete test_new_window_with_direction_logs_warning_for_old_tmux (dead code)
- Remove unused has_gte_version, has_lt_version, has_lte_version imports

Author: tony

tests/test_window.py

@@ -12,7 +12,6 @@
 
 from libtmux import exc
 from libtmux._internal.query_list import ObjectDoesNotExist
-from libtmux.common import has_gte_version, has_lt_version, has_lte_version
 from libtmux.constants import (
     PaneDirection,
     ResizeAdjustmentDirection,
@@ -158,12 +157,8 @@ def test_split_shell(session: Session) -> None:
     assert window.window_width is not None
 
     assert float(first_pane.pane_height) <= ((float(window.window_width) + 1) / 2)
-    if has_gte_version("3.2"):
-        pane_start_command = pane.pane_start_command or ""
-        assert pane_start_command.replace('"', "") == cmd
-
-    else:
-        assert pane.pane_start_command == cmd
+    pane_start_command = pane.pane_start_command or ""
+    assert pane_start_command.replace('"', "") == cmd
 
 
 def test_split_horizontal(session: Session) -> None:
@@ -187,30 +182,17 @@ def test_split_size(session: Session) -> None:
     window = session.new_window(window_name="split window size")
     window.resize(height=100, width=100)
 
-    if has_gte_version("3.1"):
-        pane = window.split(size=10)
-        assert pane.pane_height == "10"
-
-        pane = window.split(direction=PaneDirection.Right, size=10)
-        assert pane.pane_width == "10"
+    pane = window.split(size=10)
+    assert pane.pane_height == "10"
 
-        pane = window.split(size="10%")
-        assert pane.pane_height == "8"
+    pane = window.split(direction=PaneDirection.Right, size=10)
+    assert pane.pane_width == "10"
 
-        pane = window.split(direction=PaneDirection.Right, size="10%")
-        assert pane.pane_width == "8"
-    else:
-        window_height_before = (
-            int(window.window_height) if isinstance(window.window_height, str) else 0
-        )
-        window_width_before = (
-            int(window.window_width) if isinstance(window.window_width, str) else 0
-        )
-        pane = window.split(size="10%")
-        assert pane.pane_height == str(int(window_height_before * 0.1))
+    pane = window.split(size="10%")
+    assert pane.pane_height == "8"
 
-        pane = window.split(direction=PaneDirection.Right, size="10%")
-        assert pane.pane_width == str(int(window_width_before * 0.1))
+    pane = window.split(direction=PaneDirection.Right, size="10%")
+    assert pane.pane_width == "8"
 
 
 class WindowRenameFixture(t.NamedTuple):
@@ -297,9 +279,8 @@ def test_set_show_window_options(session: Session) -> None:
     assert window.show_window_option("main-pane-height") == 40
     assert window.show_window_options()["main-pane-height"] == 40
 
-    if has_gte_version("2.3"):
-        window.set_window_option("pane-border-format", " #P ")
-        assert window.show_window_option("pane-border-format") == " #P "
+    window.set_window_option("pane-border-format", " #P ")
+    assert window.show_window_option("pane-border-format") == " #P "
 
 
 def test_empty_window_option_returns_None(session: Session) -> None:
@@ -321,13 +302,10 @@ def test_show_window_option(session: Session) -> None:
 
 
 def test_show_window_option_unknown(session: Session) -> None:
-    """Window.show_window_option raises UnknownOption for bad option key."""
+    """Window.show_window_option raises InvalidOption for bad option key."""
     window = session.new_window(window_name="test_window")
 
-    cmd_exception: type[exc.OptionError] = exc.UnknownOption
-    if has_gte_version("3.0"):
-        cmd_exception = exc.InvalidOption
-    with pytest.raises(cmd_exception):
+    with pytest.raises(exc.InvalidOption):
         window.show_window_option("moooz")
 
 
@@ -348,15 +326,11 @@ def test_set_window_option_ambiguous(session: Session) -> None:
 
 
 def test_set_window_option_invalid(session: Session) -> None:
-    """Window.set_window_option raises ValueError for invalid option key."""
+    """Window.set_window_option raises InvalidOption for invalid option key."""
     window = session.new_window(window_name="test_window")
 
-    if has_gte_version("2.4"):
-        with pytest.raises(exc.InvalidOption):
-            window.set_window_option("afewewfew", 43)
-    else:
-        with pytest.raises(exc.UnknownOption):
-            window.set_window_option("afewewfew", 43)
+    with pytest.raises(exc.InvalidOption):
+        window.set_window_option("afewewfew", 43)
 
 
 def test_move_window(session: Session) -> None:
@@ -384,10 +358,6 @@ def test_select_layout_accepts_no_arg(server: Server, session: Session) -> None:
     window.select_layout()
 
 
-@pytest.mark.skipif(
-    has_lt_version("3.2"),
-    reason="needs filter introduced in tmux >= 3.2",
-)
 def test_empty_window_name(session: Session) -> None:
     """New windows can be created with empty string for window name."""
     session.set_option("automatic-rename", "off")
@@ -426,10 +396,6 @@ class WindowSplitEnvironmentFixture(t.NamedTuple):
 ]
 
 
-@pytest.mark.skipif(
-    has_lt_version("3.0"),
-    reason="needs -e flag for split-window which was introduced in 3.0",
-)
 @pytest.mark.parametrize(
     list(WindowSplitEnvironmentFixture._fields),
     WINDOW_SPLIT_ENV_FIXTURES,
@@ -457,10 +423,6 @@ def test_split_with_environment(
         assert pane.capture_pane()[-2] == v
 
 
-@pytest.mark.skipif(
-    has_lte_version("3.1"),
-    reason="3.2 has the -Z flag on split-window",
-)
 def test_split_window_zoom(
     session: Session,
 ) -> None:
@@ -483,33 +445,6 @@ def test_split_window_zoom(
     assert pane_with_zoom.height == pane_with_zoom.window_height
 
 
-@pytest.mark.skipif(
-    has_gte_version("3.0"),
-    reason="3.0 has the -e flag on split-window",
-)
-def test_split_with_environment_logs_warning_for_old_tmux(
-    session: Session,
-    caplog: pytest.LogCaptureFixture,
-) -> None:
-    """Verify splitting window with environment variables warns if tmux too old."""
-    env = shutil.which("env")
-    assert env is not None, "Cannot find usable `env` in Path."
-
-    window = session.new_window(window_name="split_with_environment")
-    window.split(
-        shell=f"{env} PS1='$ ' sh",
-        environment={"ENV_VAR": "pane"},
-    )
-
-    assert any("Environment flag ignored" in record.msg for record in caplog.records), (
-        "Warning missing"
-    )
-
-
-@pytest.mark.skipif(
-    has_lt_version("2.9"),
-    reason="resize-window only exists in tmux 2.9+",
-)
 def test_resize(
     session: Session,
 ) -> None:
@@ -586,10 +521,6 @@ def test_resize(
     assert window_height_before < window_height_expanded
 
 
-@pytest.mark.skipif(
-    has_lt_version("3.2"),
-    reason="Only 3.2+ has the -a and -b flag on new-window",
-)
 def test_new_window_with_direction(
     session: Session,
 ) -> None:
@@ -619,32 +550,6 @@ def test_new_window_with_direction(
     assert window_before.window_index == "2"
 
 
-@pytest.mark.skipif(
-    has_gte_version("3.2"),
-    reason="Only 3.2+ has the -a and -b flag on new-window",
-)
-def test_new_window_with_direction_logs_warning_for_old_tmux(
-    session: Session,
-    caplog: pytest.LogCaptureFixture,
-) -> None:
-    """Verify new window with direction create a warning if tmux is too old."""
-    window = session.active_window
-    window.refresh()
-
-    window.new_window(
-        window_name="window_with_direction",
-        direction=WindowDirection.After,
-    )
-
-    assert any("Window target ignored" in record.msg for record in caplog.records), (
-        "Warning missing"
-    )
-
-    assert any("Direction flag ignored" in record.msg for record in caplog.records), (
-        "Warning missing"
-    )
-
-
 def test_window_context_manager(session: Session) -> None:
     """Test Window context manager functionality."""
     with session.new_window() as window: