bugfix: correct casting of return value from adc as it was always overflowing the 8 bit result

deadprogram · conejoninja · commit d04e68bef858 · 2024-10-29T07:28:29.000+01:00
Signed-off-by: deadprogram &lt;ron@hybridgroup.com&gt;
diff --git a/pcf8591/pcf8591.go b/pcf8591/pcf8591.go
@@ -76,7 +76,7 @@ func (p ADCPin) Get() uint16 {
 	p.d.bus.Tx(p.d.Address, tx, rx)
 
 	// scale result to 16bit value like other ADCs
-	return uint16(rx[1] << 8)
+	return uint16(rx[1]) << 8
 }
 
 // Configure here just for interface compatibility.

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ func (p ADCPin) Get() uint16 {`
`76`	`76`	`p.d.bus.Tx(p.d.Address, tx, rx)`
`77`	`77`
`78`	`78`	`// scale result to 16bit value like other ADCs`
`79`		`- return uint16(rx[1] << 8)`
	`79`	`+ return uint16(rx[1]) << 8`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`// Configure here just for interface compatibility.`