Commit 953cb8a
committed
Guard the dispatch jobs against forks, not the lint
titanium-sdk carried `github.repository_owner == 'tidev'` and the module repos
did not -- an inherited asymmetry, not a decision. Worse, this branch had it on
the wrong job: once notify stopped depending on lint, guarding lint stopped
guarding anything. A fork would skip the one job that is useful there and still
run both dispatch jobs, which fail because a fork holds no dispatch token.
The guard now sits on the two jobs that reach outside the repo, in all 17 repos.
Forks lint their own apidoc changes, which is worth having, and produce no
failing dispatch runs.
It is about noise, not security. A fork has no REGEN_DOCS_GITHUB_TOKEN, and even
with one the payload names the fork, which is not on titanium-www's allowlist --
that allowlist is the actual boundary.1 parent f277a97 commit 953cb8a
1 file changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | 45 | | |
48 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
60 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
61 | 67 | | |
62 | 68 | | |
63 | 69 | | |
| |||
0 commit comments