switching to assert.Empty from assert.Equal empty (#181)

tobiasehlert · web-flow · commit 35a2a1b6e85c · 2023-01-24T17:46:57.000+01:00
diff --git a/src/TibiaCharactersCharacterV3_test.go b/src/TibiaCharactersCharacterV3_test.go
@@ -110,7 +110,7 @@ func TestNumber3(t *testing.T) {
 	assert.Equal("Zunera", characterJson.Characters.Character.FormerWorlds[1])
 	assert.Equal("Bubble", characterJson.Characters.Character.MarriedTo)
 	assert.Equal("2022-03-08T00:09:13Z", characterJson.Characters.Character.DeletionDate)
-	assert.Equal("", characterJson.Characters.Character.LastLogin)
+	assert.Empty(characterJson.Characters.Character.LastLogin)
 	assert.Equal("Free Account", characterJson.Characters.Character.AccountStatus)
 	assert.Equal("Fansite Admin", characterJson.Characters.AccountInformation.Position)
 	assert.Empty(characterJson.Characters.AccountInformation.LoyaltyTitle)
diff --git a/src/TibiaFansitesV3_test.go b/src/TibiaFansitesV3_test.go
@@ -44,7 +44,7 @@ func TestFansites(t *testing.T) {
 	assert.Equal("Discord server.", tibiaDataFansite.Specials[1])
 	assert.Equal("GitHub participant.", tibiaDataFansite.Specials[2])
 	assert.False(tibiaDataFansite.FansiteItem)
-	assert.Equal("", tibiaDataFansite.FansiteItemURL)
+	assert.Empty(tibiaDataFansite.FansiteItemURL)
 
 	tibiaGalleryFansite := fansitesJson.Fansites.SupportedFansites[8]
 	assert.Equal("TibiaGallery.com", tibiaGalleryFansite.Name)
diff --git a/src/TibiaHighscoresV3_test.go b/src/TibiaHighscoresV3_test.go
@@ -17,7 +17,7 @@ func TestHighscoresAll(t *testing.T) {
 	highscoresJson := TibiaHighscoresV3Impl("", experience, "all", 1, string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", highscoresJson.Highscores.World)
+	assert.Empty(highscoresJson.Highscores.World)
 	assert.Equal("experience", highscoresJson.Highscores.Category)
 	assert.Equal("all", highscoresJson.Highscores.Vocation)
 	assert.Equal(12, highscoresJson.Highscores.HighscoreAge)
@@ -35,7 +35,7 @@ func TestHighscoresAll(t *testing.T) {
 	assert.Equal("Bona", firstHighscore.World)
 	assert.Equal(2197, firstHighscore.Level)
 	assert.Equal(176271164607, firstHighscore.Value)
-	assert.Equal("", firstHighscore.Title)
+	assert.Empty(firstHighscore.Title)
 
 	lastHighscore := highscoresJson.Highscores.HighscoreList[49]
 	assert.Equal(50, lastHighscore.Rank)
@@ -44,7 +44,7 @@ func TestHighscoresAll(t *testing.T) {
 	assert.Equal("Refugia", lastHighscore.World)
 	assert.Equal(1701, lastHighscore.Level)
 	assert.Equal(81816135617, lastHighscore.Value)
-	assert.Equal("", lastHighscore.Title)
+	assert.Empty(lastHighscore.Title)
 }
 
 func TestHighscoresLoyalty(t *testing.T) {
diff --git a/src/TibiaHousesHouseV3_test.go b/src/TibiaHousesHouseV3_test.go
@@ -19,7 +19,7 @@ func TestCormaya10(t *testing.T) {
 
 	assert.Equal(54025, houseJson.House.Houseid)
 	assert.Equal("Premia", houseJson.House.World)
-	assert.Equal("", houseJson.House.Town) //depends on TibiaDataHousesMapResolver
+	assert.Empty(houseJson.House.Town) //depends on TibiaDataHousesMapResolver
 	assert.Equal("Cormaya 10", houseJson.House.Name)
 	assert.Equal("house", houseJson.House.Type)
 	assert.Equal(3, houseJson.House.Beds)
@@ -59,7 +59,7 @@ func TestCormaya11(t *testing.T) {
 
 	assert.Equal(54026, houseJson.House.Houseid)
 	assert.Equal("Premia", houseJson.House.World)
-	assert.Equal("", houseJson.House.Town) //depends on TibiaDataHousesMapResolver
+	assert.Empty(houseJson.House.Town) //depends on TibiaDataHousesMapResolver
 	assert.Equal("Cormaya 11", houseJson.House.Name)
 	assert.Equal("house", houseJson.House.Type)
 	assert.Equal(2, houseJson.House.Beds)
@@ -96,7 +96,7 @@ func TestCormaya9c(t *testing.T) {
 
 	assert.Equal(54023, houseJson.House.Houseid)
 	assert.Equal("Premia", houseJson.House.World)
-	assert.Equal("", houseJson.House.Town) //depends on TibiaDataHousesMapResolver
+	assert.Empty(houseJson.House.Town) //depends on TibiaDataHousesMapResolver
 	assert.Equal("Cormaya 9c", houseJson.House.Name)
 	assert.Equal("house", houseJson.House.Type)
 	assert.Equal(2, houseJson.House.Beds)
@@ -133,7 +133,7 @@ func TestBeachHomeApartmentsFlat14(t *testing.T) {
 
 	assert.Equal(10214, houseJson.House.Houseid)
 	assert.Equal("Premia", houseJson.House.World)
-	assert.Equal("", houseJson.House.Town) //depends on TibiaDataHousesMapResolver
+	assert.Empty(houseJson.House.Town) //depends on TibiaDataHousesMapResolver
 	assert.Equal("Beach Home Apartments, Flat 14", houseJson.House.Name)
 	assert.Equal("house", houseJson.House.Type)
 	assert.Equal(1, houseJson.House.Beds)
@@ -170,7 +170,7 @@ func TestBeachHomeApartmentsFlat15(t *testing.T) {
 
 	assert.Equal(10215, houseJson.House.Houseid)
 	assert.Equal("Premia", houseJson.House.World)
-	assert.Equal("", houseJson.House.Town) //depends on TibiaDataHousesMapResolver
+	assert.Empty(houseJson.House.Town) //depends on TibiaDataHousesMapResolver
 	assert.Equal("Beach Home Apartments, Flat 15", houseJson.House.Name)
 	assert.Equal("house", houseJson.House.Type)
 	assert.Equal(1, houseJson.House.Beds)
diff --git a/src/TibiaNewsV3_test.go b/src/TibiaNewsV3_test.go
@@ -19,7 +19,7 @@ func TestNewsById(t *testing.T) {
 
 	assert.Equal(6529, newsArticleJson.News.ID)
 	assert.Equal("2022-01-12", newsArticleJson.News.Date)
-	assert.Equal("", newsArticleJson.News.Title)
+	assert.Empty(newsArticleJson.News.Title)
 	assert.Equal("development", newsArticleJson.News.Category)
 	assert.Equal("ticker", newsArticleJson.News.Type)
 	assert.Equal("https://www.tibia.com/news/?subtopic=newsarchive&id=6529", newsArticleJson.News.TibiaURL)
@@ -39,7 +39,7 @@ func TestNews6512(t *testing.T) {
 
 	assert.Equal(6512, newsArticleJson.News.ID)
 	assert.Equal("2022-01-04", newsArticleJson.News.Date)
-	assert.Equal("", newsArticleJson.News.Title)
+	assert.Empty(newsArticleJson.News.Title)
 	assert.Equal("community", newsArticleJson.News.Category)
 	assert.Equal("ticker", newsArticleJson.News.Type)
 	assert.Equal("https://www.tibia.com/news/?subtopic=newsarchive&id=6512", newsArticleJson.News.TibiaURL)
@@ -61,7 +61,7 @@ func TestNews6481(t *testing.T) {
 	assert.Equal("2021-12-22", newsArticleJson.News.Date)
 	assert.Equal("New Mounts", newsArticleJson.News.Title)
 	assert.Equal("development", newsArticleJson.News.Category)
-	assert.Equal("", newsArticleJson.News.Type)
+	assert.Empty(newsArticleJson.News.Type)
 	assert.Equal("https://www.tibia.com/news/?subtopic=newsarchive&id=6481", newsArticleJson.News.TibiaURL)
 	assert.Equal("New mounts have been added to the Store today!\nThe origins of the Emerald Raven, Mystic Raven, and Radiant Raven are shrouded in darkness, as no written record nor tale told by even the most knowing storytellers mentions but a trace of them. Superstition surrounds them, as some see these gigantic birds as an echo of a long forgotten past, while others believe them to herald hitherto unknown events. What is clear is that they are highly intelligent beings which make great companions if they deem somebody worthy.\n\nClick on image to enlarge.\n\nOnce bought, your character can use the mount ingame anytime, no matter if you are a free account or a Premium account.\nGet yourself a corvid companion!Your Community Managers ", newsArticleJson.News.Content)
 	assert.Equal("<p>New mounts have been added to the Store today!</p>\n<p>The origins of the <strong>Emerald Raven</strong>, <strong>Mystic Raven</strong>, and <strong>Radiant Raven</strong> are shrouded in darkness, as no written record nor tale told by even the most knowing storytellers mentions but a trace of them. Superstition surrounds them, as some see these gigantic birds as an echo of a long forgotten past, while others believe them to herald hitherto unknown events. What is clear is that they are highly intelligent beings which make great companions if they deem somebody worthy.</p>\n<figure><center><img style=\"cursor: pointer;\" src=\"https://static.tibia.com/images/news/emeraldraven_small.jpg\" onclick=\"ImageInNewWindow(&#39;https://static.tibia.com/images/news/emeraldraven.jpg&#39;)\"/></center>\n<figcaption><center><em>Click on image to enlarge.</em></center></figcaption>\n</figure>\n<p>Once bought, your character can use the mount ingame anytime, no matter if you are a free account or a Premium account.</p>\n<p>Get yourself a corvid companion!<br/>Your Community Managers</p> ", newsArticleJson.News.ContentHTML)
diff --git a/src/TibiaSpellsSpellV3_test.go b/src/TibiaSpellsSpellV3_test.go
@@ -17,7 +17,7 @@ func TestFindPerson(t *testing.T) {
 	findPersonJson := TibiaSpellsSpellV3Impl("Find Person", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", findPersonJson.Spells.Spell.Description)
+	assert.Empty(findPersonJson.Spells.Spell.Description)
 	assert.Equal("Find Person", findPersonJson.Spells.Spell.Name)
 	assert.Equal("find person", findPersonJson.Spells.Spell.Spell)
 	assert.True(findPersonJson.Spells.Spell.HasSpellInformation)
@@ -55,7 +55,7 @@ func TestHeavyMagicMissileRune(t *testing.T) {
 	hmmJson := TibiaSpellsSpellV3Impl("Heavy Magic Missile Rune", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", hmmJson.Spells.Spell.Description)
+	assert.Empty(hmmJson.Spells.Spell.Description)
 	assert.Equal("Heavy Magic Missile Rune", hmmJson.Spells.Spell.Name)
 	assert.Equal("heavy magic missile rune", hmmJson.Spells.Spell.Spell)
 	assert.True(hmmJson.Spells.Spell.HasSpellInformation)
@@ -104,7 +104,7 @@ func TestAnnihilation(t *testing.T) {
 	annihilationJson := TibiaSpellsSpellV3Impl("Annihilation", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", annihilationJson.Spells.Spell.Description)
+	assert.Empty(annihilationJson.Spells.Spell.Description)
 	assert.Equal("Annihilation", annihilationJson.Spells.Spell.Name)
 	assert.Equal("annihilation", annihilationJson.Spells.Spell.Spell)
 	assert.True(annihilationJson.Spells.Spell.HasSpellInformation)
@@ -137,7 +137,7 @@ func TestBruiseBane(t *testing.T) {
 	bruisebaneJson := TibiaSpellsSpellV3Impl("Bruise Bane", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", bruisebaneJson.Spells.Spell.Description)
+	assert.Empty(bruisebaneJson.Spells.Spell.Description)
 	assert.Equal("Bruise Bane", bruisebaneJson.Spells.Spell.Name)
 	assert.Equal("bruise bane", bruisebaneJson.Spells.Spell.Spell)
 	assert.True(bruisebaneJson.Spells.Spell.HasSpellInformation)
@@ -170,7 +170,7 @@ func TestCurePoisonRune(t *testing.T) {
 	curepoisonruneJson := TibiaSpellsSpellV3Impl("Cure Poison Rune", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", curepoisonruneJson.Spells.Spell.Description)
+	assert.Empty(curepoisonruneJson.Spells.Spell.Description)
 	assert.Equal("Cure Poison Rune", curepoisonruneJson.Spells.Spell.Name)
 	assert.Equal("cure poison rune", curepoisonruneJson.Spells.Spell.Spell)
 	assert.True(curepoisonruneJson.Spells.Spell.HasSpellInformation)
@@ -199,7 +199,7 @@ func TestConvinceCreatureRune(t *testing.T) {
 	convincecreatureruneJson := TibiaSpellsSpellV3Impl("Convince Creature Rune", string(data))
 	assert := assert.New(t)
 
-	assert.Equal("", convincecreatureruneJson.Spells.Spell.Description)
+	assert.Empty(convincecreatureruneJson.Spells.Spell.Description)
 	assert.Equal("Convince Creature Rune", convincecreatureruneJson.Spells.Spell.Name)
 	assert.Equal("convince creature rune", convincecreatureruneJson.Spells.Spell.Spell)
 	assert.True(convincecreatureruneJson.Spells.Spell.HasSpellInformation)
