(thunderstore-api) Refactor API fetch functions to remove async/await where unnecessary for improved performance

Author: Oksamies

packages/thunderstore-api/src/delete/packageWiki.ts

@@ -6,7 +6,7 @@ import {
   packageWikiPageDeleteRequestDataSchema,
 } from "../schemas/requestSchemas";
 
-export async function deletePackageWikiPage(
+export function deletePackageWikiPage(
   props: ApiEndpointProps<
     PackageWikiPageDeleteRequestParams,
     object,
@@ -16,15 +16,13 @@ export async function deletePackageWikiPage(
   const { config, params, data } = props;
   const path = `api/experimental/package/${params.namespace_id}/${params.package_name}/wiki/`;
 
-  return await apiFetch({
-    args: {
-      config: config,
-      path: path,
-      request: {
-        method: "DELETE",
-        cache: "no-store",
-        body: JSON.stringify(data),
-      },
+  return apiFetch({
+    config: config,
+    path: path,
+    request: {
+      method: "DELETE",
+      cache: "no-store",
+      body: JSON.stringify(data),
     },
     requestSchema: packageWikiPageDeleteRequestDataSchema,
     queryParamsSchema: undefined,

packages/thunderstore-api/src/delete/teamDisband.ts

@@ -9,14 +9,12 @@ export function teamDisband(
   const path = `/api/cyberstorm/team/${params.team_name}/disband/`;
 
   return apiFetch({
-    args: {
-      config,
-      path,
-      request: {
-        method: "DELETE",
-      },
-      useSession: true,
+    config,
+    path,
+    request: {
+      method: "DELETE",
     },
+    useSession: true,
     requestSchema: undefined,
     queryParamsSchema: undefined,
     responseSchema: undefined,

packages/thunderstore-api/src/delete/teamRemoveMember.ts

@@ -11,14 +11,12 @@ export function teamRemoveMember(
   const path = `/api/cyberstorm/team/${params.team_name}/member/${params.username}/remove/`;
 
   return apiFetch({
-    args: {
-      config,
-      path,
-      request: {
-        method: "DELETE",
-      },
-      useSession: true,
+    config,
+    path,
+    request: {
+      method: "DELETE",
     },
+    useSession: true,
     requestSchema: undefined,
     queryParamsSchema: undefined,
     responseSchema: undefined,

packages/thunderstore-api/src/delete/teamServiceAccountRemove.ts

@@ -11,14 +11,12 @@ export function teamServiceAccountRemove(
   const path = `/api/cyberstorm/service-account/${params.uuid}/delete/`;
 
   return apiFetch({
-    args: {
-      config,
-      path,
-      request: {
-        method: "DELETE",
-      },
-      useSession: true,
+    config,
+    path,
+    request: {
+      method: "DELETE",
     },
+    useSession: true,
     requestSchema: undefined,
     queryParamsSchema: undefined,
     responseSchema: undefined,

packages/thunderstore-api/src/delete/userDelete.ts

@@ -8,14 +8,12 @@ export function userDelete(
   const path = `/api/cyberstorm/user/delete/`;
 
   return apiFetch({
-    args: {
-      config,
-      path,
-      request: {
-        method: "DELETE",
-      },
-      useSession: true,
+    config,
+    path,
+    request: {
+      method: "DELETE",
     },
+    useSession: true,
     requestSchema: undefined,
     queryParamsSchema: undefined,
     responseSchema: undefined,

packages/thunderstore-api/src/delete/userLinkedAccountDisconnect.ts

@@ -16,14 +16,12 @@ export function userLinkedAccountDisconnect(
   const path = `/api/cyberstorm/user/linked-account/${params.provider}/disconnect/`;
 
   return apiFetch({
-    args: {
-      config,
-      path,
-      request: {
-        method: "DELETE",
-      },
-      useSession: true,
+    config,
+    path,
+    request: {
+      method: "DELETE",
     },
+    useSession: true,
     requestSchema: userLinkedAccountDisconnectRequestDataSchema,
     queryParamsSchema: undefined,
     responseSchema: undefined,

packages/thunderstore-api/src/get/community.ts

@@ -6,17 +6,15 @@ import {
   communityResponseDataSchema,
 } from "../schemas/responseSchemas";
 
-export async function fetchCommunity(
+export function fetchCommunity(
   props: ApiEndpointProps<CommunityRequestParams, object, object>
 ): Promise<CommunityResponseData> {
   const { config, params } = props;
   const path = `api/cyberstorm/community/${params.community_id}/`;
 
-  return await apiFetch({
-    args: {
-      config,
-      path,
-    },
+  return apiFetch({
+    config,
+    path,
     requestSchema: undefined,
     queryParamsSchema: undefined,
     responseSchema: communityResponseDataSchema,

packages/thunderstore-api/src/get/communityFilters.ts

@@ -9,17 +9,15 @@ import {
   communityFiltersResponseDataSchema,
 } from "../schemas/responseSchemas";
 
-export async function fetchCommunityFilters(
+export function fetchCommunityFilters(
   props: ApiEndpointProps<CommunityFiltersRequestParams, object, object>
 ): Promise<CommunityFiltersResponseData> {
   const { config, params } = props;
   const path = `api/cyberstorm/community/${params.community_id}/filters/`;
 
-  return await apiFetch({
-    args: {
-      config,
-      path,
-    },
+  return apiFetch({
+    config,
+    path,
     requestSchema: undefined,
     queryParamsSchema: communityFiltersRequestParamsSchema,
     responseSchema: communityFiltersResponseDataSchema,

packages/thunderstore-api/src/get/communityList.ts

@@ -10,7 +10,7 @@ import {
   communityListResponseDataSchema,
 } from "../schemas/responseSchemas";
 
-export async function fetchCommunityList(
+export function fetchCommunityList(
   props: ApiEndpointProps<object, CommunityListRequestQueryParams, object>
 ): Promise<CommunityListResponseData> {
   const {
@@ -27,12 +27,10 @@ export async function fetchCommunityList(
   } = props;
   const path = "api/cyberstorm/community/";
 
-  return await apiFetch({
-    args: {
-      config,
-      path,
-      queryParams,
-    },
+  return apiFetch({
+    config,
+    path,
+    queryParams,
     requestSchema: undefined,
     queryParamsSchema: communityListRequestQueryParamsSchema,
     responseSchema: communityListResponseDataSchema,

packages/thunderstore-api/src/get/communityPackageListings.ts

@@ -12,7 +12,7 @@ import {
   packageListingsResponseDataSchema,
 } from "../schemas/responseSchemas";
 
-export async function fetchCommunityPackageListings(
+export function fetchCommunityPackageListings(
   props: ApiEndpointProps<
     CommunityPackageListingsRequestParams,
     PackageListingsRequestQueryParams,
@@ -37,12 +37,10 @@ export async function fetchCommunityPackageListings(
       { key: "deprecated", value: false, impotent: false },
     ],
   } = props;
-  return await apiFetch({
-    args: {
-      config,
-      path: `api/cyberstorm/listing/${params.community_id.toLowerCase()}/`,
-      queryParams,
-    },
+  return apiFetch({
+    config,
+    path: `api/cyberstorm/listing/${params.community_id.toLowerCase()}/`,
+    queryParams,
     requestSchema: communityPackageListingsRequestParamsSchema,
     queryParamsSchema: packageListingsRequestQueryParamsSchema,
     responseSchema: packageListingsResponseDataSchema,