test(image-loader): fix failing tests

Author: edoparearyee

e2e/protractor.conf.js

@@ -9,23 +9,23 @@ exports.config = {
   capabilities: {
     browserName: 'chrome',
     chromeOptions: {
-      args: ['--headless', '--no-sandbox', '--window-size=1024,768']
-    }
+      args: ['--headless', '--no-sandbox', '--window-size=1024,768'],
+    },
   },
   directConnect: true,
   baseUrl: 'http://localhost:4200/',
   framework: 'jasmine',
   jasmineNodeOpts: {
     showColors: true,
     defaultTimeoutInterval: 30000,
-    print: function() {}
+    print: function() {},
   },
   onPrepare() {
     require('ts-node').register({
-      project: require('path').join(__dirname, './tsconfig.e2e.json')
+      project: require('path').join(__dirname, './tsconfig.e2e.json'),
     });
     jasmine
       .getEnv()
       .addReporter(new SpecReporter({ spec: { displayStacktrace: true } }));
-  }
+  },
 };

e2e/src/app.po.ts

@@ -8,13 +8,13 @@ export class AppPage {
   scrollTo(x: number = 0, y: number = 0) {
     browser.executeScript(`return window.scrollTo(${x}, ${y});`);
     return browser.wait(() =>
-      this.getScrollYPosition().then(posY => posY === y)
+      this.getScrollYPosition().then(posY => posY === y),
     );
   }
 
   scrollIntoView(selector: string) {
     return browser.executeScript(
-      `return document.querySelector('${selector}').scrollIntoView()`
+      `return document.querySelector('${selector}').scrollIntoView()`,
     );
   }
 
@@ -34,21 +34,10 @@ export class AppPage {
   }
 
   setWindowSize(x: number, y: number) {
-    browser.driver
+    return browser.driver
       .manage()
       .window()
       .setSize(x, y);
-    return browser.wait(() =>
-      this.getWindowSize().then(
-        (size: any) => size.height === y && size.width === x
-      )
-    );
-  }
-
-  getWindowSize() {
-    return browser.executeScript(
-      `return { height: window.outerHeight, width: window.outerWidth };`
-    );
   }
 
   getScrollYPosition() {
@@ -125,19 +114,19 @@ export class AppPage {
 
   isImageTopLoaded() {
     return this.getImageTopLoaderCompClass().then((result: string) =>
-      result.includes('sn-image-loaded')
+      result.includes('sn-image-loaded'),
     );
   }
 
   isImageBottomLoaded() {
     return this.getImageBottomLoaderCompClass().then((result: string) =>
-      result.includes('sn-image-loaded')
+      result.includes('sn-image-loaded'),
     );
   }
 
   isVideoLoaded() {
     return this.getVideoElementClass().then((result: string) =>
-      result.includes('sn-video-loaded')
+      result.includes('sn-video-loaded'),
     );
   }
 

e2e/src/image-loader.e2e-spec.ts

@@ -134,6 +134,7 @@ describe('ImageLoader Lib E2E Tests', function() {
       let expected = '0';
       expect(result).toEqual(expected);
 
+      page.scrollTo();
       page.setWindowSize(400, 580);
       page.scrollToImageBottomElement();
       result = page.getImageBottomLoadedCountElementText();