Skip to content

Commit 37a7f86

Browse files
committed
perf(ImageLoader): use rxjs from event instead of angular HostBinding api
prevent change detection running on each resize event by using rxjs fromEvent and ouside of ngZone
1 parent 4075f94 commit 37a7f86

File tree

8 files changed

+3655
-1619
lines changed

8 files changed

+3655
-1619
lines changed

README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
This project was generated with [Angular CLI](https://github.com/angular/angular-cli) version 1.5.4.
66

7-
A simple progressive/responsive/lazy loading image library for [Angular (2/4+)][angular] that detects browser size and loads the appropriate image only when the element is in view. Classes are attributed and events emited on image loads. This package requires [angular-inviewport][angular-inviewport].
7+
A simple progressive/responsive/lazy loading image library for [Angular][angular] that detects browser size and loads the appropriate image only when the element is in view. Classes are attributed and events emited on image loads. This package requires [@thisissoon/angular-inviewport][angular-inviewport].
88

99
<img src="https://raw.githubusercontent.com/thisissoon/angular-image-loader/master/src/assets/example.gif" alt="example">
1010

@@ -44,13 +44,13 @@ A working example can be found inside [/src](https://github.com/thisissoon/angul
4444
### `app.component.html`
4545

4646
```html
47-
<sn-image-loader
48-
[image]="image"
49-
[sizes]="sizes"
50-
imgClass="foo"
51-
alt="lorem ipsum"
52-
(placeholderLoaded)="onPlaceholderLoad($event)"
53-
(imageLoaded)="onImageLoad($event)">
47+
<sn-image-loader
48+
[image]="image"
49+
[sizes]="sizes"
50+
imgClass="foo"
51+
alt="lorem ipsum"
52+
(placeholderLoaded)="onPlaceholderLoad($event)"
53+
(imageLoaded)="onImageLoad($event)">
5454
</sn-image-loader>
5555
```
5656

@@ -89,7 +89,7 @@ export class AppComponent {
8989
public onPlaceholderLoad(imageLoadedEvent: ImageLoadedEvent) {
9090
// Do something
9191
}
92-
92+
9393
public onImageLoad(imageLoadedEvent: ImageLoadedEvent) {
9494
// Do something
9595
}

index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export { ImageLoaderModule } from './src/app/image-loader/image-loader.module';
22
export { ImageLoaderComponent } from './src/app/image-loader/image-loader.component';
33
import { loadedClass, notLoadedClass } from './src/app/image-loader/shared/classes';
4-
import { eventPathResize, eventResize } from './src/app/image-loader/shared/events';
4+
import { eventResize } from './src/app/image-loader/shared/events';
55
import { ResponsiveImage, RetinaImage, Size } from './src/app/image-loader/shared/image.model';
66
import { Breakpoint } from './src/app/image-loader/shared/breakpoint.model';

0 commit comments

Comments
 (0)