Release 3.7.0 (#438)

* docs update

* dev release 3.7.0-0

* fix usage of arrays in eip 712 signing

* release pkg

Author: nkrishang

contracts/dynamic-contracts/extension/AccountPermissions.sol

@@ -247,7 +247,7 @@ abstract contract AccountPermissions is IAccountPermissions, EIP712 {
             abi.encode(
                 TYPEHASH,
                 _req.signer,
-                _req.approvedTargets,
+                keccak256(abi.encodePacked(_req.approvedTargets)),
                 _req.nativeTokenLimitPerTransaction,
                 _req.permissionStartTimestamp,
                 _req.permissionEndTimestamp,

contracts/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@thirdweb-dev/contracts",
   "description": "Collection of smart contracts deployable via the thirdweb SDK, dashboard and CLI",
-  "version": "3.6.2",
+  "version": "3.7.0",
   "license": "Apache-2.0",
   "repository": {
     "type": "git",

docs/Account.md

@@ -21,23 +21,6 @@ Deposit funds for this account in Entrypoint.
 
 
 
-### changeRole
-
-```solidity
-function changeRole(IAccountPermissions.RoleRequest _req, bytes _signature) external nonpayable
-```
-
-
-
-
-
-#### Parameters
-
-| Name | Type | Description |
-|---|---|---|
-| _req | IAccountPermissions.RoleRequest | undefined |
-| _signature | bytes | undefined |
-
 ### contractURI
 
 ```solidity
@@ -125,28 +108,57 @@ EIP 4337 factory for this contract.
 |---|---|---|
 | _0 | address | undefined |
 
-### getAllRoleMembers
+### getAllActiveSigners
 
 ```solidity
-function getAllRoleMembers(bytes32 _role) external view returns (address[])
+function getAllActiveSigners() external view returns (struct IAccountPermissions.SignerPermissions[] signers)
 ```
 
-Returns all accounts that have a role.
+Returns all signers with active permissions to use the account.
 
 
 
-#### Parameters
+
+#### Returns
 
 | Name | Type | Description |
 |---|---|---|
-| _role | bytes32 | undefined |
+| signers | IAccountPermissions.SignerPermissions[] | undefined |
+
+### getAllAdmins
+
+```solidity
+function getAllAdmins() external view returns (address[])
+```
+
+Returns all admins of the account.
+
+
+
 
 #### Returns
 
 | Name | Type | Description |
 |---|---|---|
 | _0 | address[] | undefined |
 
+### getAllSigners
+
+```solidity
+function getAllSigners() external view returns (struct IAccountPermissions.SignerPermissions[] signers)
+```
+
+Returns all active and inactive signers of the account.
+
+
+
+
+#### Returns
+
+| Name | Type | Description |
+|---|---|---|
+| signers | IAccountPermissions.SignerPermissions[] | undefined |
+
 ### getDeposit
 
 ```solidity
@@ -181,66 +193,66 @@ Return the account nonce. This method returns the next sequential nonce. For a n
 |---|---|---|
 | _0 | uint256 | undefined |
 
-### getRoleRestrictions
+### getPermissionsForSigner
 
 ```solidity
-function getRoleRestrictions(bytes32 _role) external view returns (struct IAccountPermissions.RoleRestrictions)
+function getPermissionsForSigner(address signer) external view returns (struct IAccountPermissions.SignerPermissions)
 ```
 
-Returns the role restrictions for a given role.
+Returns the restrictions under which a signer can use the smart wallet.
 
 
 
 #### Parameters
 
 | Name | Type | Description |
 |---|---|---|
-| _role | bytes32 | undefined |
+| signer | address | undefined |
 
 #### Returns
 
 | Name | Type | Description |
 |---|---|---|
-| _0 | IAccountPermissions.RoleRestrictions | undefined |
+| _0 | IAccountPermissions.SignerPermissions | undefined |
 
-### getRoleRestrictionsForAccount
+### initialize
 
 ```solidity
-function getRoleRestrictionsForAccount(address _account) external view returns (struct IAccountPermissions.RoleRestrictions)
+function initialize(address _defaultAdmin, bytes) external nonpayable
 ```
 
-Returns the role held by a given account along with its restrictions.
+Initializes the smart contract wallet.
 
 
 
 #### Parameters
 
 | Name | Type | Description |
 |---|---|---|
-| _account | address | undefined |
-
-#### Returns
-
-| Name | Type | Description |
-|---|---|---|
-| _0 | IAccountPermissions.RoleRestrictions | undefined |
+| _defaultAdmin | address | undefined |
+| _1 | bytes | undefined |
 
-### initialize
+### isActiveSigner
 
 ```solidity
-function initialize(address _defaultAdmin, bytes) external nonpayable
+function isActiveSigner(address signer) external view returns (bool)
 ```
 
-Initializes the smart contract wallet.
+Returns whether the given account is an active signer on the account.
 
 
 
 #### Parameters
 
 | Name | Type | Description |
 |---|---|---|
-| _defaultAdmin | address | undefined |
-| _1 | bytes | undefined |
+| signer | address | undefined |
+
+#### Returns
+
+| Name | Type | Description |
+|---|---|---|
+| _0 | bool | undefined |
 
 ### isAdmin
 
@@ -442,10 +454,10 @@ Lets a contract admin set the URI for contract-level metadata.
 |---|---|---|
 | _uri | string | keccak256 hash of the role. e.g. keccak256("TRANSFER_ROLE") |
 
-### setRoleRestrictions
+### setPermissionsForSigner
 
 ```solidity
-function setRoleRestrictions(IAccountPermissions.RoleRestrictions _restrictions) external nonpayable
+function setPermissionsForSigner(IAccountPermissions.SignerPermissionRequest _req, bytes _signature) external nonpayable
 ```
 
 
@@ -456,7 +468,8 @@ function setRoleRestrictions(IAccountPermissions.RoleRestrictions _restrictions)
 
 | Name | Type | Description |
 |---|---|---|
-| _restrictions | IAccountPermissions.RoleRestrictions | undefined |
+| _req | IAccountPermissions.SignerPermissionRequest | undefined |
+| _signature | bytes | undefined |
 
 ### supportsInterface
 
@@ -504,10 +517,10 @@ function validateUserOp(UserOperation userOp, bytes32 userOpHash, uint256 missin
 |---|---|---|
 | validationData | uint256 | undefined |
 
-### verifyRoleRequest
+### verifySignerPermissionRequest
 
 ```solidity
-function verifyRoleRequest(IAccountPermissions.RoleRequest req, bytes signature) external view returns (bool success, address signer)
+function verifySignerPermissionRequest(IAccountPermissions.SignerPermissionRequest req, bytes signature) external view returns (bool success, address signer)
 ```
 
 
@@ -518,7 +531,7 @@ function verifyRoleRequest(IAccountPermissions.RoleRequest req, bytes signature)
 
 | Name | Type | Description |
 |---|---|---|
-| req | IAccountPermissions.RoleRequest | undefined |
+| req | IAccountPermissions.SignerPermissionRequest | undefined |
 | signature | bytes | undefined |
 
 #### Returns
@@ -552,7 +565,7 @@ Withdraw funds for this account from Entrypoint.
 ### AdminUpdated
 
 ```solidity
-event AdminUpdated(address indexed account, bool isAdmin)
+event AdminUpdated(address indexed signer, bool isAdmin)
 ```
 
 Emitted when an admin is set or removed.
@@ -563,7 +576,7 @@ Emitted when an admin is set or removed.
 
 | Name | Type | Description |
 |---|---|---|
-| account `indexed` | address | undefined |
+| signer `indexed` | address | undefined |
 | isAdmin  | bool | undefined |
 
 ### ContractURIUpdated
@@ -599,41 +612,23 @@ event Initialized(uint8 version)
 |---|---|---|
 | version  | uint8 | undefined |
 
-### RoleAssignment
-
-```solidity
-event RoleAssignment(bytes32 indexed role, address indexed account, address indexed signer, IAccountPermissions.RoleRequest request)
-```
-
-Emitted when a role is granted / revoked by an authorized party.
-
-
-
-#### Parameters
-
-| Name | Type | Description |
-|---|---|---|
-| role `indexed` | bytes32 | undefined |
-| account `indexed` | address | undefined |
-| signer `indexed` | address | undefined |
-| request  | IAccountPermissions.RoleRequest | undefined |
-
-### RoleUpdated
+### SignerPermissionsUpdated
 
 ```solidity
-event RoleUpdated(bytes32 indexed role, IAccountPermissions.RoleRestrictions restrictions)
+event SignerPermissionsUpdated(address indexed authorizingSigner, address indexed targetSigner, IAccountPermissions.SignerPermissionRequest permissions)
 ```
 
-Emitted when the restrictions for a given role are updated.
+Emitted when permissions for a signer are updated.
 
 
 
 #### Parameters
 
 | Name | Type | Description |
 |---|---|---|
-| role `indexed` | bytes32 | undefined |
-| restrictions  | IAccountPermissions.RoleRestrictions | undefined |
+| authorizingSigner `indexed` | address | undefined |
+| targetSigner `indexed` | address | undefined |
+| permissions  | IAccountPermissions.SignerPermissionRequest | undefined |