Removal of PriceWatcherService #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csproj now has consistent formatting. The InMemoryProductsRepository is now registered as a singleton. Removed unused using statements at the beginning of Program.cs Signed-off-by: Kenny Pflug <kenny.pflug@thinktecture.com>
This commit is quite large and incorporates the following things: - introduction of Unit-Of-Work pattern for ADO.NET for MS SQL Server and in-memory data - clear separation of Business Logic and I/O - IAsyncFactory that asynchronously opens the underlying SqlConnection and starts transaction if necessary - the Transactional Outbox pattern to go from at-most-once to at-least-once when publishing messages to the broker Signed-off-by: Kenny Pflug <kenny.pflug@thinktecture.com>
…iguration Signed-off-by: Kenny Pflug <kenny.pflug@thinktecture.com>
Signed-off-by: Kenny Pflug <kenny.pflug@thinktecture.com>
Signed-off-by: Kenny Pflug <kenny.pflug@thinktecture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
PriceDropControlleris now part of theProductsService. I introduced a simple unit of work and async factory that encapsulate ADO.NET for SQL Server and In-Memory data. This allows access to the database in a completely asynchronous manner while keeping the business logic in the controller completely decoupled from any specific data access technology.PriceDropController.PriceWatcherControllerwith itsRegisterendpoint to the PriceDropNotifier service. It currently uses an in-memory data access layer with a simplified Unit-of-Work pattern to store registrations.PriceDropNotifierControllernow fetches all registrations and sends emails accordingly.Issues I still have: