Add more tests for AbstractRequest and AbstractResponse. Closes #125

Author: johnkary

tests/Omnipay/Common/Message/AbstractRequestTest.php

@@ -189,4 +189,56 @@ public function testNotifyUrl()
         $this->assertSame($this->request, $this->request->setNotifyUrl('https://www.example.com/notify'));
         $this->assertSame('https://www.example.com/notify', $this->request->getNotifyUrl());
     }
+
+    public function testInitializedParametersAreSet()
+    {
+        $params = array('testMode' => 'success');
+
+        $this->request->initialize($params);
+
+        $this->assertSame($this->request->getTestMode(), 'success');
+    }
+
+    public function testGetParameters()
+    {
+        $this->request->setTestMode(true);
+        $this->request->setToken('asdf');
+
+        $expected = array(
+            'testMode' => true,
+            'token' => 'asdf',
+        );
+        $this->assertEquals($expected, $this->request->getParameters());
+    }
+
+    public function testCanValidateExistingParameters()
+    {
+        $this->request->setTestMode(true);
+        $this->request->setToken('asdf');
+
+        $this->assertNull($this->request->validate('testMode', 'token'));
+    }
+
+    /**
+     * @expectedException \Omnipay\Common\Exception\InvalidRequestException
+     */
+    public function testInvalidParametersThrowsException()
+    {
+        $this->request->setTestMode(true);
+
+        $this->request->validate('testMode', 'token');
+    }
+
+    public function testNoCurrencyReturnedIfCurrencyNotSet()
+    {
+        $this->assertNull($this->request->getCurrencyNumeric());
+    }
+
+    /**
+     * @expectedException \Omnipay\Common\Exception\RuntimeException
+     */
+    public function testMustSendRequestBeforeGettingResponse()
+    {
+        $this->request->getResponse();
+    }
 }

tests/Omnipay/Common/Message/AbstractResponseTest.php

@@ -24,5 +24,16 @@ public function testDefaultMethods()
         $this->assertNull($response->getData());
         $this->assertNull($response->getTransactionReference());
         $this->assertNull($response->getMessage());
+        $this->assertNull($response->getCode());
+    }
+
+    /**
+     * @expectedException \Omnipay\Common\Exception\RuntimeException
+     */
+    public function testCannotRedirectResponseThatIsNotRedirectResponseInterface()
+    {
+        $response = m::mock('\Omnipay\Common\Message\AbstractResponse[isSuccessful,isRedirect]');
+
+        $response->getRedirectResponse();
     }
 }