call phpstan extension instead of copying it

Author: Khartir

phpstan.neon

@@ -26,7 +26,7 @@ parameters:
             count: 1
             path: src/Rules/Error/SafeRuleError.php
         -
-            message: '#^Calling PHPStan\\Type\\BitwiseFlagHelper::bitwiseOrContainsConstant\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version\.$#'
+            message: '#^Calling PHPStan\\Type\\Php\\JsonThrowOnErrorDynamicReturnTypeExtension\:\:getTypeFromFunctionCall\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version\.$#'
             identifier: phpstanApi.method
             count: 1
             path: src/Type/Php/JsonDecodeDynamicReturnTypeExtension.php

src/Type/Php/JsonDecodeDynamicReturnTypeExtension.php

@@ -4,27 +4,23 @@
 namespace TheCodingMachine\Safe\PHPStan\Type\Php;
 
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\FunctionReflection;
-use PHPStan\Reflection\ParametersAcceptorSelector;
-use PHPStan\Type\BitwiseFlagHelper;
-use PHPStan\Type\Constant\ConstantStringType;
-use PHPStan\Type\ConstantScalarType;
-use PHPStan\Type\ConstantTypeHelper;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\DynamicFunctionReturnTypeExtension;
 use PHPStan\Type\NeverType;
-use PHPStan\Type\ObjectWithoutClassType;
+use PHPStan\Type\Php\JsonThrowOnErrorDynamicReturnTypeExtension;
 use PHPStan\Type\Type;
-use PHPStan\Type\TypeCombinator;
-use Safe\Exceptions\JsonException;
 
 /**
  * @see \PHPStan\Type\Php\JsonThrowOnErrorDynamicReturnTypeExtension
  */
 final class JsonDecodeDynamicReturnTypeExtension implements DynamicFunctionReturnTypeExtension
 {
     public function __construct(
-        private readonly BitwiseFlagHelper $bitwiseFlagAnalyser,
+        private readonly JsonThrowOnErrorDynamicReturnTypeExtension $phpstanCheck,
+        private readonly ReflectionProvider $reflectionProvider,
     ) {
     }
 
@@ -35,74 +31,14 @@ public function isFunctionSupported(FunctionReflection $functionReflection): boo
 
     public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
     {
-        $defaultReturnType = ParametersAcceptorSelector::selectFromArgs(
-            $scope,
-            $functionCall->getArgs(),
-            $functionReflection->getVariants(),
-        )->getReturnType();
+        $functionReflection = $this->reflectionProvider->getFunction(new Name('json_decode'), null);
+        $result = $this->phpstanCheck->getTypeFromFunctionCall($functionReflection, $functionCall, $scope);
 
-        return $this->narrowTypeForJsonDecode($functionCall, $scope, $defaultReturnType);
-    }
-
-    private function narrowTypeForJsonDecode(FuncCall $funcCall, Scope $scope, Type $fallbackType): Type
-    {
-        $args = $funcCall->getArgs();
-        $isForceArray = $this->isForceArray($funcCall, $scope);
-        if (!isset($args[0])) {
-            return $fallbackType;
-        }
-
-        $firstValueType = $scope->getType($args[0]->value);
-        if ([] !== $firstValueType->getConstantStrings()) {
-            $types = [];
-
-            foreach ($firstValueType->getConstantStrings() as $constantString) {
-                $types[] = $this->resolveConstantStringType($constantString, $isForceArray);
-            }
-
-            return TypeCombinator::union(...$types);
-        }
-
-        if ($isForceArray) {
-            return TypeCombinator::remove($fallbackType, new ObjectWithoutClassType());
-        }
-
-        return $fallbackType;
-    }
-
-    /**
-     * Is "json_decode(..., true)"?
-     */
-    private function isForceArray(FuncCall $funcCall, Scope $scope): bool
-    {
-        $args = $funcCall->getArgs();
-        if (!isset($args[1])) {
-            return false;
-        }
-
-        $secondArgType = $scope->getType($args[1]->value);
-        $secondArgValue = 1 === \count($secondArgType->getConstantScalarValues()) ? $secondArgType->getConstantScalarValues()[0] : null;
-
-        if (is_bool($secondArgValue)) {
-            return $secondArgValue;
-        }
-
-        if ($secondArgValue !== null || !isset($args[3])) {
-            return false;
-        }
-
-        // depends on used constants, @see https://www.php.net/manual/en/json.constants.php#constant.json-object-as-array
-        return $this->bitwiseFlagAnalyser->bitwiseOrContainsConstant($args[3]->value, $scope, 'JSON_OBJECT_AS_ARRAY')->yes();
-    }
-
-    private function resolveConstantStringType(ConstantStringType $constantStringType, bool $isForceArray): Type
-    {
-        try {
-            $decodedValue = \Safe\json_decode($constantStringType->getValue(), $isForceArray);
-        } catch (JsonException) {
+        // if PHPStan reports null and there is a json error, then an invalid constant string was passed
+        if ($result->isNull()->yes() && JSON_ERROR_NONE !== json_last_error()) {
             return new NeverType();
         }
 
-        return ConstantTypeHelper::getTypeFromValue($decodedValue);
+        return $result;
     }
 }

tests/Type/Php/data/json_decode_return.php

@@ -33,12 +33,3 @@ function(string $json): void {
     $value = \Safe\json_decode($json, true);
     \PHPStan\Testing\assertType('mixed~object', $value);
 };
-
-function(string $json): void {
-    /** @var '{}'|'null' $json */
-    $value = \Safe\json_decode($json);
-    \PHPStan\Testing\assertType('stdClass|null', $value);
-
-    $value = \Safe\json_decode($json, true);
-    \PHPStan\Testing\assertType('array{}|null', $value);
-};