Fix use of MagicField with phpType on a proxy class without magic __get method (#405)

Authored-by: Michael Vostrikov <mikhail.vostrikov@vseinstrumenti.ru>

Author: michael-vostrikov

src/FieldsBuilder.php

@@ -32,6 +32,7 @@
 use TheCodingMachine\GraphQLite\Mappers\Root\RootTypeMapperInterface;
 use TheCodingMachine\GraphQLite\Middlewares\FieldHandlerInterface;
 use TheCodingMachine\GraphQLite\Middlewares\FieldMiddlewareInterface;
+use TheCodingMachine\GraphQLite\Middlewares\MissingMagicGetException;
 use TheCodingMachine\GraphQLite\Parameters\InputTypeProperty;
 use TheCodingMachine\GraphQLite\Parameters\ParameterInterface;
 use TheCodingMachine\GraphQLite\Reflection\CachedDocBlockFactory;
@@ -618,8 +619,9 @@ private function getQueryFieldsFromSourceFields(array $sourceFields, ReflectionC
                 } else {
                     $phpTypeStr = $sourceField->getPhpType();
                     Assert::notNull($phpTypeStr);
-                    $refMethod = $refClass->getMethod('__get');
-                    $type = $this->resolvePhpType($phpTypeStr, $refClass, $refMethod);
+                    $magicGefRefMethod = $this->getMagicGetMethodFromSourceClassOrProxy($refClass);
+
+                    $type = $this->resolvePhpType($phpTypeStr, $refClass, $magicGefRefMethod);
                 }
             }
 
@@ -644,6 +646,32 @@ public function handle(QueryFieldDescriptor $fieldDescriptor): ?FieldDefinition
         return $queryList;
     }
 
+    /**
+     * @throws ReflectionException
+     * @throws MissingAnnotationException
+     * @throws MissingMagicGetException
+     */
+    private function getMagicGetMethodFromSourceClassOrProxy(ReflectionClass $proxyRefClass): ReflectionMethod
+    {
+        $magicGet = '__get';
+        if ($proxyRefClass->hasMethod($magicGet)) {
+            return $proxyRefClass->getMethod($magicGet);
+        }
+
+        $typeField = $this->annotationReader->getTypeAnnotation($proxyRefClass);
+        if ($typeField === null) {
+            throw MissingAnnotationException::missingTypeException($proxyRefClass->getName());
+        }
+
+        $sourceClassName = $typeField->getClass();
+        $sourceRefClass = new ReflectionClass($sourceClassName);
+        if (! $sourceRefClass->hasMethod($magicGet)) {
+            throw MissingMagicGetException::cannotFindMagicGet($sourceClassName);
+        }
+
+        return $sourceRefClass->getMethod($magicGet);
+    }
+
     /**
      * @param ReflectionClass<object> $refClass
      *

tests/FieldsBuilderTest.php

@@ -50,6 +50,7 @@
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithFailWith;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithInvalidPrefetchParameter;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithMagicProperty;
+use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithMagicPropertyType;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithPrefetchMethod;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithSourceFieldInterface;
 use TheCodingMachine\GraphQLite\Fixtures\TestTypeWithSourceFieldInvalidParameterAnnotation;
@@ -786,4 +787,21 @@ public function testMagicField(): void
         $this->expectExceptionMessage('You cannot use a @MagicField annotation on an object that does not implement the __get() magic method. The class stdClass must implement a __get() method.');
         $result = $resolve(new stdClass(), [], null, $this->createMock(ResolveInfo::class));
     }
+
+    public function testProxyClassWithMagicPropertyOfPhpType(): void
+    {
+        $controller = new TestTypeWithMagicPropertyType();
+
+        $queryProvider = $this->buildFieldsBuilder();
+
+        $fields = $queryProvider->getFields($controller);
+
+        $query = $fields['foo'];
+        $this->assertSame('foo', $query->name);
+
+        $resolve = $query->resolveFn;
+        $result = $resolve(new TestTypeWithMagicProperty(), [], null, $this->createMock(ResolveInfo::class));
+
+        $this->assertSame('foo', $result);
+    }
 }

tests/Fixtures/TestTypeWithMagicPropertyType.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace TheCodingMachine\GraphQLite\Fixtures;
+
+use TheCodingMachine\GraphQLite\Annotations\Type;
+use TheCodingMachine\GraphQLite\Annotations\MagicField;
+
+/**
+ * @Type(class=TestTypeWithMagicProperty::class)
+ * @MagicField(name="foo", phpType="string")
+ */
+class TestTypeWithMagicPropertyType
+{
+}