Code style fixes

Author: devmaslov

src/AnnotationReader.php

@@ -398,7 +398,6 @@ private function isErrorImportant(string $annotationClass, string $docComment, s
      *
      * @param ReflectionClass<T> $refClass
      * @param class-string<A> $annotationClass
-     * @param bool $inherited
      *
      * @return A[]
      *
@@ -530,12 +529,12 @@ public function getPropertyAnnotations(ReflectionProperty $refProperty, string $
             if (PHP_MAJOR_VERSION >= 8) {
                 $attributes = $refProperty->getAttributes();
                 $toAddAnnotations = array_merge($toAddAnnotations, array_map(
-                  static function ($attribute) {
-                      return $attribute->newInstance();
-                  },
-                  array_filter($attributes, static function ($annotation) use ($annotationClass): bool {
-                      return is_a($annotation->getName(), $annotationClass, true);
-                  })
+                    static function ($attribute) {
+                        return $attribute->newInstance();
+                    },
+                    array_filter($attributes, static function ($annotation) use ($annotationClass): bool {
+                        return is_a($annotation->getName(), $annotationClass, true);
+                    })
                 ));
             }
         } catch (AnnotationException $e) {

src/Annotations/Field.php

@@ -49,9 +49,11 @@ public function __construct(array $attributes = [], ?string $name = null, ?strin
         $this->inputType = $inputType ?? $attributes['inputType'] ?? null;
 
         $forValue = $for ?? $attributes['for'] ?? null;
-        if ($forValue) {
-            $this->for = (array) $forValue;
+        if (! $forValue) {
+            return;
         }
+
+        $this->for = (array) $forValue;
     }
 
     /**

src/FailedResolvingInputType.php

@@ -5,6 +5,7 @@
 namespace TheCodingMachine\GraphQLite;
 
 use RuntimeException;
+
 use function sprintf;
 
 class FailedResolvingInputType extends RuntimeException
@@ -16,11 +17,11 @@ public static function createForMissingConstructorParameter(string $class, strin
 
     public static function createForDecorator(string $class): self
     {
-        return new self("Input type '$class' cannot be a decorator.");
+        return new self(sprintf("Input type '%s' cannot be a decorator.", $class));
     }
 
     public static function createForNotInstantiableClass(string $class): self
     {
-        return new self("Class '$class' annotated with @Input must be instantiable.");
+        return new self(sprintf("Class '%s' annotated with @Input must be instantiable.", $class));
     }
 }

src/FieldsBuilder.php

@@ -41,6 +41,7 @@
 use TheCodingMachine\GraphQLite\Utils\PropertyAccessor;
 use Webmozart\Assert\Assert;
 
+use function array_diff_key;
 use function array_fill_keys;
 use function array_intersect_key;
 use function array_keys;
@@ -56,6 +57,7 @@
 use function reset;
 use function rtrim;
 use function trim;
+
 use const PHP_EOL;
 
 /**
@@ -187,7 +189,8 @@ public function getInputFields(string $className, string $inputName, bool $isUpd
         }
 
         // Make sure @Field annotations applied to parent's private properties are taken into account as well.
-        if ($parent = $refClass->getParentClass()) {
+        $parent = $refClass->getParentClass();
+        if ($parent) {
             $parentFields = $this->getInputFields($parent->getName(), $inputName, $isUpdate);
             $fields = array_merge($fields, array_diff_key($parentFields, $fields));
         }

src/Mappers/AbstractTypeMapper.php

@@ -325,7 +325,7 @@ public function mapClassToInputType(string $className): ResolvableMutableInputIn
 
         $input = $this->getMaps()->getInputByObjectClass($className);
         if ($input !== null) {
-            [ $typeName, $description, $isUpdate ] = $input;
+            [$typeName, $description, $isUpdate] = $input;
             return $this->inputTypeGenerator->mapInput($className, $typeName, $description, $isUpdate);
         }
 
@@ -357,7 +357,7 @@ public function mapNameToType(string $typeName): Type
 
         $input = $this->getMaps()->getInputByGraphQLInputTypeName($typeName);
         if ($input !== null) {
-            [ $className, $description, $isUpdate ] = $input;
+            [$className, $description, $isUpdate] = $input;
             return $this->inputTypeGenerator->mapInput($className, $typeName, $description, $isUpdate);
         }
 

src/Middlewares/SourcePropertyResolver.php

@@ -7,6 +7,7 @@
 use TheCodingMachine\GraphQLite\GraphQLRuntimeException;
 use TheCodingMachine\GraphQLite\Utils\PropertyAccessor;
 use Webmozart\Assert\Assert;
+
 use function get_class;
 use function is_object;
 

src/QueryFieldDescriptor.php

@@ -16,6 +16,8 @@
 use TheCodingMachine\GraphQLite\Middlewares\SourceResolver;
 use TheCodingMachine\GraphQLite\Parameters\ParameterInterface;
 
+use function is_array;
+
 /**
  * A class that describes a field to be created.
  * To contains getters and setters to alter the field behaviour.
@@ -134,8 +136,6 @@ public function setPrefetchMethodName(?string $prefetchMethodName): void
      * Sets the callable targeting the resolver function if the resolver function is part of a service.
      * This should not be used in the context of a field middleware.
      * Use getResolver/setResolver if you want to wrap the resolver in another method.
-     *
-     * @param callable $callable
      */
     public function setCallable(callable $callable): void
     {
@@ -159,9 +159,6 @@ public function setTargetMethodOnSource(string $targetMethodOnSource): void
         $this->magicProperty = null;
     }
 
-    /**
-     * @param string|null $targetPropertyOnSource
-     */
     public function setTargetPropertyOnSource(?string $targetPropertyOnSource): void
     {
         if ($this->originalResolver !== null) {

src/SchemaFactory.php

@@ -52,6 +52,7 @@
 use TheCodingMachine\GraphQLite\Utils\NamespacedCache;
 use TheCodingMachine\GraphQLite\Utils\Namespaces\NamespaceFactory;
 
+use function apcu_enabled;
 use function array_map;
 use function array_reverse;
 use function class_exists;

src/Types/InputType.php

@@ -11,6 +11,9 @@
 use TheCodingMachine\GraphQLite\FieldsBuilder;
 use TheCodingMachine\GraphQLite\Parameters\InputTypeProperty;
 use TheCodingMachine\GraphQLite\Utils\PropertyAccessor;
+
+use function array_diff_key;
+use function array_flip;
 use function array_key_exists;
 
 /**
@@ -30,8 +33,8 @@ class InputType extends MutableInputObjectType implements ResolvableMutableInput
     public function __construct(string $className, string $inputName, ?string $description, bool $isUpdate, FieldsBuilder $fieldsBuilder)
     {
         $reflection = new ReflectionClass($className);
-        if (!$reflection->isInstantiable()) {
-          throw FailedResolvingInputType::createForNotInstantiableClass($className);
+        if (! $reflection->isInstantiable()) {
+            throw FailedResolvingInputType::createForNotInstantiableClass($className);
         }
 
         $this->fields = $fieldsBuilder->getInputFields($className, $inputName, $isUpdate);
@@ -133,7 +136,7 @@ private function getClassConstructParameterNames(): array
         $refClass = new ReflectionClass($this->className);
         $constructor = $refClass->getConstructor();
 
-        if (!$constructor) {
+        if (! $constructor) {
             return [];
         }
 

src/Utils/AccessPropertyException.php

@@ -1,22 +1,27 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TheCodingMachine\GraphQLite\Utils;
 
 use LogicException;
 
+use function sprintf;
+use function ucfirst;
+
 class AccessPropertyException extends LogicException
 {
     public static function createForUnreadableProperty(string $class, string $propertyName): self
     {
         $name = ucfirst($propertyName);
 
-        return new self("Could not get value from property '$class::$propertyName'. Either make the property public or add a public getter for it like 'get$name' or 'is$name' with no required parameters");
+        return new self(sprintf("Could not get value from property '%s::%s'. Either make the property public or add a public getter for it like 'get%s' or 'is%s' with no required parameters", $class, $propertyName, $name, $name));
     }
 
     public static function createForUnwritableProperty(string $class, string $propertyName): self
     {
         $name = ucfirst($propertyName);
 
-        return new self("Could not set value for property '$class::$propertyName'. Either make the property public or add a public setter for it like this: 'set$name'");
+        return new self(sprintf("Could not set value for property '%s::%s'. Either make the property public or add a public setter for it like this: 'set%s'", $class, $propertyName, $name));
     }
 }