Caching annotations and optimizing calls to Factory annotation

Author: moufmouf

src/AnnotationReader.php

@@ -128,6 +128,7 @@ public function getSourceFields(ReflectionClass $refClass): array
 
     public function getFactoryAnnotation(ReflectionMethod $refMethod): ?Factory
     {
+        $this->store[$refMethod->getDeclaringClass()->getName().'::'.$refMethod->getName()] = 1;
         /** @var Factory|null $factoryAnnotation */
         $factoryAnnotation = $this->getMethodAnnotation($refMethod, Factory::class);
         return $factoryAnnotation;
@@ -165,6 +166,8 @@ private function getClassAnnotation(ReflectionClass $refClass, string $annotatio
         } while ($refClass);
         return null;
     }
+    
+    private $methodAnnotationCache = [];
 
     /**
      * Returns a method annotation and handles correctly errors.
@@ -173,8 +176,13 @@ private function getClassAnnotation(ReflectionClass $refClass, string $annotatio
      */
     private function getMethodAnnotation(ReflectionMethod $refMethod, string $annotationClass)
     {
+        $cacheKey = $refMethod->getDeclaringClass()->getName().'::'.$refMethod->getName().'_'.$annotationClass;
+        if (isset($this->methodAnnotationCache[$cacheKey])) {
+            return $this->methodAnnotationCache[$cacheKey];
+        }
+
         try {
-            return $this->reader->getMethodAnnotation($refMethod, $annotationClass);
+            return $this->methodAnnotationCache[$cacheKey] = $this->reader->getMethodAnnotation($refMethod, $annotationClass);
         } catch (AnnotationException $e) {
             switch ($this->mode) {
                 case self::STRICT_MODE:

src/Mappers/GlobTypeMapper.php

@@ -264,6 +264,7 @@ private function buildMap(): void
         $this->mapClassToFactory = [];
         $this->mapInputNameToFactory = [];
 
+        /** @var ReflectionClass[] $classes */
         $classes = $this->getClassList();
         foreach ($classes as $className => $refClass) {
             $type = $this->annotationReader->getTypeAnnotation($refClass);
@@ -279,7 +280,12 @@ private function buildMap(): void
                 $this->storeTypeInCache($className, $type, $refClass->getFileName());
             }
 
+            $isAbstract = $refClass->isAbstract();
+
             foreach ($refClass->getMethods() as $method) {
+                if (!$method->isPublic() || ($isAbstract && !$method->isStatic())) {
+                    continue;
+                }
                 $factory = $this->annotationReader->getFactoryAnnotation($method);
                 if ($factory !== null) {
                     [$inputName, $className] = $this->inputTypeUtils->getInputTypeNameAndClassName($method);