feat: Added trigger_http variable to repository-function submodule (#93)

* - Added trigger_http variable to repository-function submodule
- Made event_trigger variable optional
(either trigger_http OR event_trigger should be supplied)
- Added trigger URL to outputs

* Correcting whitespace

* Adding missing failure pol variable
Generate docs

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>

Author: Nathan-Gauci-Kasna

modules/repository-function/README.md

@@ -22,7 +22,8 @@ is a tested reference of how to use this submodule with the
 | description | The description of the function. | `string` | `"Processes events."` | no |
 | entry\_point | The name of a method in the function source which will be invoked when the function is executed. | `string` | n/a | yes |
 | environment\_variables | A set of key/value environment variable pairs to assign to the function. | `map(string)` | `{}` | no |
-| event\_trigger | A source that fires events in response to a condition in another service. | `map(string)` | n/a | yes |
+| event\_trigger | A source that fires events in response to a condition in another service. | `map(string)` | `{}` | no |
+| event\_trigger\_failure\_policy\_retry | A toggle to determine if the function should be retried on failure. | `bool` | `false` | no |
 | ingress\_settings | The ingress settings for the function. Allowed values are ALLOW\_ALL, ALLOW\_INTERNAL\_AND\_GCLB and ALLOW\_INTERNAL\_ONLY. Changes to this field will recreate the cloud function. | `string` | `"ALLOW_ALL"` | no |
 | labels | A set of key/value label pairs to assign to any lableable resources. | `map(string)` | `{}` | no |
 | name | The name to apply to any nameable resources. | `string` | n/a | yes |
@@ -32,13 +33,15 @@ is a tested reference of how to use this submodule with the
 | service\_account\_email | The service account to run the function as. | `string` | `""` | no |
 | source\_repository\_url | The URL of the repository which contains the function source code. | `string` | n/a | yes |
 | timeout\_s | The amount of time in seconds allotted for the execution of the function. | `number` | `60` | no |
+| trigger\_http | Wheter to use HTTP trigger instead of the event trigger. | `bool` | `null` | no |
 | vpc\_connector | The VPC Network Connector that this cloud function can connect to. It should be set up as fully-qualified URI. The format of this field is projects/\*/locations/\*/connectors/\*. | `string` | `null` | no |
 | vpc\_connector\_egress\_settings | The egress settings for the connector, controlling what traffic is diverted through it. Allowed values are ALL\_TRAFFIC and PRIVATE\_RANGES\_ONLY. If unset, this field preserves the previously set value. | `string` | `null` | no |
 
 ## Outputs
 
 | Name | Description |
 |------|-------------|
+| https\_trigger\_url | URL which triggers function execution. |
 | name | The name of the function. |
 
 <!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->

modules/repository-function/main.tf

@@ -21,12 +21,21 @@ resource "google_cloudfunctions_function" "main" {
   timeout                       = var.timeout_s
   entry_point                   = var.entry_point
   ingress_settings              = var.ingress_settings
+  trigger_http                  = var.trigger_http
   vpc_connector_egress_settings = var.vpc_connector_egress_settings
   vpc_connector                 = var.vpc_connector
 
-  event_trigger {
-    event_type = var.event_trigger["event_type"]
-    resource   = var.event_trigger["resource"]
+  dynamic "event_trigger" {
+    for_each = var.trigger_http != null ? [] : [1]
+
+    content {
+      event_type = var.event_trigger["event_type"]
+      resource   = var.event_trigger["resource"]
+
+      failure_policy {
+        retry = var.event_trigger_failure_policy_retry
+      }
+    }
   }
 
   labels                = var.labels

modules/repository-function/outputs.tf

@@ -19,3 +19,7 @@ output "name" {
   value       = google_cloudfunctions_function.main.name
 }
 
+output "https_trigger_url" {
+  description = "URL which triggers function execution."
+  value       = var.trigger_http != null ? google_cloudfunctions_function.main.https_trigger_url : ""
+}

modules/repository-function/variables.tf

@@ -39,9 +39,16 @@ variable "environment_variables" {
 
 variable "event_trigger" {
   type        = map(string)
+  default     = {}
   description = "A source that fires events in response to a condition in another service."
 }
 
+variable "trigger_http" {
+  type        = bool
+  default     = null
+  description = "Wheter to use HTTP trigger instead of the event trigger."
+}
+
 variable "labels" {
   type        = map(string)
   default     = {}
@@ -86,6 +93,12 @@ variable "service_account_email" {
   description = "The service account to run the function as."
 }
 
+variable "event_trigger_failure_policy_retry" {
+  type        = bool
+  default     = false
+  description = "A toggle to determine if the function should be retried on failure."
+}
+
 variable "ingress_settings" {
   type        = string
   default     = "ALLOW_ALL"