Skip to content

Conversation

@daniel-cit
Copy link
Contributor

This PR adds support for GitHub Action and GitLab workflows deploy in deploy helper

@daniel-cit daniel-cit changed the title Feat: add support for GitHub and gitlab in helper feat: add support for GitHub and gitlab in helper Nov 11, 2025
@daniel-cit daniel-cit marked this pull request as ready for review November 12, 2025 00:46
@daniel-cit
Copy link
Contributor Author

@apeabody Could you PTAL?

@apeabody
Copy link
Contributor

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for GitHub Actions and GitLab CI/CD as alternatives to Google Cloud Build for the deployment helper. The changes are extensive, involving significant refactoring to modularize CI/CD-specific configurations, the introduction of an Executor interface to abstract CI/CD system interactions, and updates to documentation and helper scripts. The overall design is solid. However, I've identified a few critical issues: a potential modification of the source code directory, a security risk of leaking secrets in logs, and a bug in the build-type selection script that could lead to an inconsistent state. Addressing these points will greatly improve the robustness and security of the new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants