Skip to content

Conversation

@virajmehta
Copy link
Member

Closes #22

@shuyangli
Copy link
Member

For future reference: users with write access to the repo has read access to secrets. Based on the docs - I think GITHUB_TOKEN is an authn token to the actions user, so if we grant it write access it will be able to read secrets via gh cli (but I didn't verify this). So if we give the SWE bot read access only we should be fine.

Copy link
Member

@shuyangli shuyangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few feedback related comments. there are code level improvements we can make but we'll punt them to get it in.

@virajmehta virajmehta marked this pull request as ready for review December 2, 2025 19:06
@virajmehta virajmehta added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 215a1c0 Dec 2, 2025
2 of 4 checks passed
@virajmehta virajmehta deleted the viraj/pr-only branch December 2, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try migrating to a mini SWE agent

3 participants