handle naming and some code SuppressWarnings

Author: Moustafa-Elgammal

phpmd.xml

@@ -21,8 +21,9 @@
 
     <rule ref="rulesets/codesize.xml"/>
 
-    <rule ref="rulesets/naming.xml"/>
-
+    <rule ref="rulesets/naming.xml">
+        <exclude name="LongVariable"></exclude>
+    </rule>
 
     <rule ref="rulesets/design.xml" />
 

src/Entities/Chat.php

@@ -40,11 +40,11 @@ public function __construct($data)
     {
         parent::__construct($data);
 
-        $id = $this->getId();
+        $_id = $this->getId();
         $type = $this->getType();
         if (!$type) {
-            $id > 0 && $this->type = 'private';
-            $id < 0 && $this->type = 'group';
+            $_id > 0 && $this->type = 'private';
+            $_id < 0 && $this->type = 'group';
         }
     }
 

src/Entities/Payments/PreCheckoutQuery.php

@@ -33,11 +33,11 @@ class PreCheckoutQuery extends Entity
      *
      * @return Response
      */
-    public function answer(bool $ok, array $data = []): Response
+    public function answer(bool $_ok, array $data = []): Response
     {
         return Request::answerPreCheckoutQuery(array_merge([
             'pre_checkout_query_id' => $this->getId(),
-            'ok' => $ok,
+            'ok' => $_ok,
         ], $data));
     }
 

src/Entities/Payments/ShippingQuery.php

@@ -30,11 +30,11 @@ class ShippingQuery extends Entity
      *
      * @return Response
      */
-    public function answer(bool $ok, array $data = []): Response
+    public function answer(bool $_ok, array $data = []): Response
     {
         return Request::answerShippingQuery(array_merge([
             'shipping_query_id' => $this->getId(),
-            'ok' => $ok,
+            'ok' => $_ok,
         ], $data));
     }
 

src/Entities/Response.php

@@ -43,7 +43,6 @@ public function __construct(array $data)
         $this->response = $data;
 
         $is_ok = (bool)($data['ok'] ?? false);
-        $result = $data['result'] ?? null;
 
         if ($is_ok) {
             foreach ($this->requiredFields as $field) {

src/Request.php

@@ -174,13 +174,6 @@ class Request {
      */
     private static string $api_base_uri = 'https://api.telegram.org';
 
-    /**
-     * URI of the Telegram API for downloading files (relative to $api_base_url or absolute)
-     *
-     * @var string
-     */
-    private static string $api_base_download_uri = '/file/bot{API_KEY}';
-
     /**
      * The current action that is being executed
      *

src/Traits/HandlerTrait.php

@@ -15,9 +15,12 @@
 trait HandlerTrait
 {
 
+    /**
+     * @TODO @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
     public function __process(Update $update): void
     {
         // TODO: Implement __process() method.
     }
 
-}
+}

src/UpdateHandler.php

@@ -71,6 +71,8 @@ public function __construct(string $api_token = '') {
     * @param ?Update $update The custom to work with
     * @param array $config The configuration of the receiver
     * @return void
+
+    * @TODO @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public static function resolveOn(Plugin $plugin, Update $update = null, array $config = []): void {
       // TODO: Implement resolveOn() method.
@@ -94,7 +96,6 @@ public function addPlugins(Plugin|array $plugins): UpdateHandler {
             );
          }
 
-         $reflection = Toolkit::reflectionClass($plugin);
          $this->plugins[] = [
             'class' => $plugin,
             'initialized' => is_object($plugin),
@@ -250,4 +251,4 @@ public function stop(): void {
       $this->active_spreader = false;
    }
 
-}
+}