From b4004a589c2150739995878890eaa93cd89f85d5 Mon Sep 17 00:00:00 2001 From: Timothy Place Date: Wed, 26 Aug 2026 17:47:07 -0500 Subject: [PATCH 1/2] build: lower the cmake floor from 3.24 to 3.22 Nothing here uses a feature newer than 3.22. A scan of the 119-line CMakeLists for the usual 3.23/3.24 arrivals -- FILE_SET, cmake_path, TARGET_RUNTIME_DLLS, COMPILE_WARNING_AS_ERROR, VERIFY_INTERFACE_HEADER_SETS, OVERRIDE_FIND_PACKAGE, DOWNLOAD_EXTRACT_TIMESTAMP -- finds none of them. The floor appears incidental: whatever the author had installed, rather than something the build needs. Its one practical effect was excluding Ubuntu 22.04 LTS, which ships cmake 3.22.1. Anything consuming this repo as a submodule inherits the floor, so a stock 22.04 machine could not configure this project or anything built on it. The dsptap submodule carries the same incidental floor, so this change alone is not enough to configure on 22.04; a companion PR lowers it there. Verified: unchanged on macOS with cmake 4.x, and now configures and passes on Ubuntu 22.04 LTS with cmake 3.22.1, where it previously refused outright. Co-Authored-By: Claude Opus 5 --- CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 0c15d65..1b5efae 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,4 +1,7 @@ -cmake_minimum_required(VERSION 3.24) +# 3.22 is Ubuntu 22.04 LTS's stock cmake. Nothing here uses a 3.23+ feature -- +# no FILE_SET, no cmake_path, no TARGET_RUNTIME_DLLS, no CMP0135-dependent +# FetchContent URL handling -- so the higher floor only excluded the current LTS. +cmake_minimum_required(VERSION 3.22) project(MuTap VERSION 0.1.0 LANGUAGES C CXX) # ------------------------------------------------------------------------------ From ecd7b9f040ad953f0cb953f0c93b99c1349d04a2 Mon Sep 17 00:00:00 2001 From: Timothy Place Date: Wed, 26 Aug 2026 19:11:40 -0500 Subject: [PATCH 2/2] build: bump dsptap to pick up its cmake floor change dsptap carried the same incidental 3.24 floor as this repo, which meant lowering the floor here alone still left a stock Ubuntu 22.04 LTS machine unable to configure: the nested submodule refused first. That change is merged upstream, so this moves the pin onto it. Together with the previous commit, this repo now configures on cmake 3.22. ff6fc6c..41215c6 Co-Authored-By: Claude Opus 5 --- submodules/dsptap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/submodules/dsptap b/submodules/dsptap index ff6fc6c..41215c6 160000 --- a/submodules/dsptap +++ b/submodules/dsptap @@ -1 +1 @@ -Subproject commit ff6fc6c5067f675316fd07a05e9c078dbc23b1bd +Subproject commit 41215c6590f6c72e2e30b54ce373b7bc0e7967bd