Skip to content

Conversation

@hhaensel
Copy link
Contributor

@hhaensel hhaensel commented Dec 2, 2025

As JSON3 has. been deprecated and people are moving to use the new v1 of JSON, I propose to bump the compat entry.
JSON.parse() now returns a JSON.Object by default. So in order to make the PR non-breaking, I forced dicttype=Dict{String,Any} for parsing.
This restriction could be released in a later version.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.74%. Comparing base (017806e) to head (ea29128).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/OpenIDConnect.jl 25.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   50.45%   42.74%   -7.72%     
==========================================
  Files           1        1              
  Lines         109      131      +22     
==========================================
+ Hits           55       56       +1     
- Misses         54       75      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hhaensel
Copy link
Contributor Author

hhaensel commented Dec 3, 2025

@tanmaykm what do you think?

@tanmaykm
Copy link
Owner

tanmaykm commented Dec 3, 2025

Thanks @hhaensel !

@tanmaykm tanmaykm merged commit ada8249 into tanmaykm:master Dec 3, 2025
9 checks passed
@hhaensel
Copy link
Contributor Author

hhaensel commented Dec 3, 2025

Thank you for merging and releasing 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants