Make port discovery optional via settings

Author: marwan-at-work

README.md

@@ -84,7 +84,7 @@ If the extension isn't working, we recommend following these steps to troublesho
 2. Ensure that your Tailnet access controls (ACLs) are [configured to allow Tailscale Funnel](https://tailscale.com/kb/1223/tailscale-funnel/#setup) on your device.
 3. Ensure that [magicDNS and HTTPS Certificates are enabled](https://tailscale.com/kb/1153/enabling-https/) on your tailnet.
 4. If you are running `tailscaled` in a non-default path, you can set its path via the `tailscale.socketPath` setting in VS Code.
-
+ (Make port discovery optional via settings)
 ## Contribute
 
 We appreciate your help! For information on contributing to this extension, refer to the [CONTRIBUTING](CONTRIBUTING.md) document.

src/tailscale/cli.ts

@@ -35,6 +35,7 @@ export class Tailscale {
   private notifyExit?: () => void;
   private socket?: string;
   private ws?: WebSocket;
+  private snoozing?: boolean;
 
   constructor(vscode: vscodeModule) {
     this._vscode = vscode;
@@ -77,7 +78,9 @@ export class Tailscale {
 
   async init() {
     return new Promise<null>((resolve) => {
-      this.socket = vscode.workspace.getConfiguration(EXTENSION_NS).get<string>('socketPath');
+      this.socket = vscode.workspace
+        .getConfiguration(EXTENSION_NS)
+        .get<string>('portDiscovery.enabled');
       let binPath = this.tsrelayPath();
       let args = this.defaultArgs();
       let cwd = __dirname;
@@ -363,13 +366,30 @@ export class Tailscale {
       if (msg.type != 'newPort') {
         return;
       }
+      if (this.snoozing) {
+        return;
+      }
       const shouldServe = await this._vscode.window.showInformationMessage(
         msg.message,
         { modal: false },
-        'Serve'
+        'Serve',
+        'Snooze Notifications'
       );
-      if (shouldServe) {
+      if (shouldServe === 'Serve') {
         await this.runFunnel(msg.port);
+      } else if (shouldServe === 'Snooze Notifications') {
+        this.snooze();
+        const openSettings = await this._vscode.window.showInformationMessage(
+          'Snoozed for 15 minutes. You can fully turn off port discovery in the settings',
+          { modal: false },
+          'Open Settings'
+        );
+        if (openSettings) {
+          this._vscode.commands.executeCommand(
+            'workbench.action.openSettings',
+            'tailscale.portDiscovery.enabled'
+          );
+        }
       }
     });
     this._vscode.window.onDidOpenTerminal(async (e: vscode.Terminal) => {
@@ -401,6 +421,13 @@ export class Tailscale {
     });
   }
 
+  async snooze() {
+    this.snoozing = true;
+    setTimeout(() => {
+      this.snoozing = false;
+    }, 900000); // fifteen minutes
+  }
+
   async runFunnel(port: number) {
     await this.serveAdd({
       protocol: 'https',