[Security] Fix DOM XSS vulnerability in search

jdomingu · jdomingu · commit e24efdfe3322 · 2019-03-13T17:44:42.000-07:00
diff --git a/js/search.js b/js/search.js
@@ -23,7 +23,7 @@
 
     function displaySearchHeading(query) {
         var heading = document.getElementById("searchHeading");
-        heading.innerHTML = "Search results for: " + query;
+        heading.textContent = "Search results for: " + query;
     }
 
     // Get the raw search results

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`
`24`	`24`	`function displaySearchHeading(query) {`
`25`	`25`	`var heading = document.getElementById("searchHeading");`
`26`		`- heading.innerHTML = "Search results for: " + query;`
	`26`	`+ heading.textContent = "Search results for: " + query;`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`// Get the raw search results`