Skip to content

Commit 85f8f17

Browse files
committed
fix: address review comments
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
1 parent 5edb412 commit 85f8f17

File tree

4 files changed

+57
-7
lines changed

4 files changed

+57
-7
lines changed

charts/shield/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ maintainers:
1313
- name: mavimo
1414
email: marcovito.moscaritolo@sysdig.com
1515
type: application
16-
version: 1.24.4
16+
version: 1.24.2
1717
appVersion: "1.0.0"

charts/shield/templates/host/_configmap_helpers.tpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
{{- end }}
4141
4242
{{- define "host.configmap.detections" }}
43-
{{- dict "detections" (pick . "ml_policies") | toYaml }}
43+
{{- dict "detections" (pick . "ml_policies" "file_integrity_monitoring") | toYaml }}
4444
{{- end }}
4545
4646
{{/* Generate the 'host_shield_config.yaml' content */}}

charts/shield/tests/host/configmap-dragent-yaml_test.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -645,11 +645,6 @@ tests:
645645
pattern: |
646646
drift_control:
647647
enabled: false
648-
- matchRegex:
649-
path: data['dragent.yaml']
650-
pattern: |
651-
file_integrity_monitoring:
652-
enabled: false
653648
- matchRegex:
654649
path: data['dragent.yaml']
655650
pattern: |

charts/shield/tests/host/configmap-host-shield-config_test.yaml

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ tests:
2121
pattern: |
2222
features:
2323
detections:
24+
file_integrity_monitoring:
25+
enabled: false
2426
ml_policies:
2527
enabled: false
2628
posture:
@@ -50,6 +52,8 @@ tests:
5052
pattern: |
5153
features:
5254
detections:
55+
file_integrity_monitoring:
56+
enabled: false
5357
ml_policies:
5458
enabled: false
5559
posture:
@@ -79,6 +83,8 @@ tests:
7983
pattern: |
8084
features:
8185
detections:
86+
file_integrity_monitoring:
87+
enabled: false
8288
ml_policies:
8389
enabled: false
8490
posture:
@@ -108,6 +114,8 @@ tests:
108114
pattern: |
109115
features:
110116
detections:
117+
file_integrity_monitoring:
118+
enabled: false
111119
ml_policies:
112120
enabled: false
113121
posture:
@@ -137,6 +145,8 @@ tests:
137145
pattern: |
138146
features:
139147
detections:
148+
file_integrity_monitoring:
149+
enabled: false
140150
ml_policies:
141151
enabled: false
142152
posture:
@@ -161,6 +171,8 @@ tests:
161171
pattern: |
162172
features:
163173
detections:
174+
file_integrity_monitoring:
175+
enabled: false
164176
ml_policies:
165177
enabled: false
166178
posture:
@@ -193,6 +205,8 @@ tests:
193205
pattern: |-
194206
features:
195207
detections:
208+
file_integrity_monitoring:
209+
enabled: false
196210
ml_policies:
197211
enabled: false
198212
posture:
@@ -224,6 +238,8 @@ tests:
224238
pattern: |-
225239
features:
226240
detections:
241+
file_integrity_monitoring:
242+
enabled: false
227243
ml_policies:
228244
enabled: false
229245
posture:
@@ -271,6 +287,8 @@ tests:
271287
pattern: |-
272288
features:
273289
detections:
290+
file_integrity_monitoring:
291+
enabled: false
274292
ml_policies:
275293
enabled: false
276294
posture:
@@ -339,6 +357,8 @@ tests:
339357
pattern: |-
340358
features:
341359
detections:
360+
file_integrity_monitoring:
361+
enabled: false
342362
ml_policies:
343363
enabled: false
344364
posture:
@@ -427,6 +447,8 @@ tests:
427447
pattern: |-
428448
features:
429449
detections:
450+
file_integrity_monitoring:
451+
enabled: false
430452
ml_policies:
431453
enabled: false
432454
posture:
@@ -457,6 +479,8 @@ tests:
457479
pattern: |-
458480
features:
459481
detections:
482+
file_integrity_monitoring:
483+
enabled: false
460484
ml_policies:
461485
enabled: true
462486
posture:
@@ -474,6 +498,37 @@ tests:
474498
enabled: false
475499
integration_enabled: false
476500
501+
- it: Enable File Integrity Monitoring
502+
set:
503+
features:
504+
detections:
505+
file_integrity_monitoring:
506+
enabled: true
507+
asserts:
508+
- matchRegex:
509+
path: data['host-shield.yaml']
510+
pattern: |-
511+
features:
512+
detections:
513+
file_integrity_monitoring:
514+
enabled: true
515+
ml_policies:
516+
enabled: false
517+
posture:
518+
host_posture:
519+
enabled: false
520+
respond:
521+
rapid_response:
522+
enabled: false
523+
response_actions:
524+
enabled: false
525+
vulnerability_management:
526+
host_vulnerability_management:
527+
enabled: false
528+
in_use:
529+
enabled: false
530+
integration_enabled: false
531+
477532
- it: Ensure Local Forwarder
478533
set:
479534
features:

0 commit comments

Comments
 (0)