Add strict to tsconfig.json

Author: wooorm

lib/core.js

@@ -62,7 +62,7 @@ export function core(schema, defaultTagName, caseSensitive) {
 
         if (selector === undefined || selector === null) {
           node = {type: 'root', children: []}
-          // @ts-ignore Properties are not supported for roots.
+          // @ts-expect-error Properties are not supported for roots.
           children.unshift(properties)
         } else {
           node = parseSelector(selector, defaultTagName)
@@ -79,7 +79,7 @@ export function core(schema, defaultTagName, caseSensitive) {
 
             for (key in properties) {
               if (own.call(properties, key)) {
-                // @ts-ignore `node.properties` is set.
+                // @ts-expect-error `node.properties` is set.
                 addProperty(schema, node.properties, key, properties[key])
               }
             }
@@ -183,7 +183,7 @@ function addProperty(schema, properties, key, value) {
     const finalResult = []
 
     while (++index < result.length) {
-      // @ts-ignore Assume no booleans in array.
+      // @ts-expect-error Assume no booleans in array.
       finalResult[index] = parsePrimitive(info, info.property, result[index])
     }
 
@@ -192,7 +192,7 @@ function addProperty(schema, properties, key, value) {
 
   // Class names (which can be added both on the `selector` and here).
   if (info.property === 'className' && Array.isArray(properties.className)) {
-    // @ts-ignore Assume no booleans in `className`.
+    // @ts-expect-error Assume no booleans in `className`.
     result = properties.className.concat(result)
   }
 
@@ -217,7 +217,6 @@ function addChild(nodes, value) {
     }
   } else if (typeof value === 'object' && 'type' in value) {
     if (value.type === 'root') {
-      // @ts-ignore it looks like a root, TS…
       addChild(nodes, value.children)
     } else {
       nodes.push(value)

script/generate-jsx.js

@@ -12,7 +12,7 @@ fs.writeFileSync(
   path.join('test', 'jsx-build-jsx-classic.js'),
   generate(
     buildJsx(
-      // @ts-ignore Acorn nodes are assignable to ESTree nodes.
+      // @ts-expect-error Acorn nodes are assignable to ESTree nodes.
       Parser.extend(acornJsx()).parse(
         doc.replace(/'name'/, "'jsx (estree-util-build-jsx, classic)'"),
         {sourceType: 'module', ecmaVersion: 2021}
@@ -26,7 +26,7 @@ fs.writeFileSync(
   path.join('test', 'jsx-build-jsx-automatic.js'),
   generate(
     buildJsx(
-      // @ts-ignore Acorn nodes are assignable to ESTree nodes.
+      // @ts-expect-error Acorn nodes are assignable to ESTree nodes.
       Parser.extend(acornJsx()).parse(
         doc.replace(/'name'/, "'jsx (estree-util-build-jsx, automatic)'"),
         {sourceType: 'module', ecmaVersion: 2021}
@@ -38,7 +38,7 @@ fs.writeFileSync(
 
 fs.writeFileSync(
   path.join('test', 'jsx-babel-classic.js'),
-  // @ts-ignore Result always given.
+  // @ts-expect-error Result always given.
   babel.transform(doc.replace(/'name'/, "'jsx (babel, classic)'"), {
     plugins: [
       ['@babel/plugin-transform-react-jsx', {pragma: 'h', pragmaFrag: 'null'}]
@@ -48,7 +48,7 @@ fs.writeFileSync(
 
 fs.writeFileSync(
   path.join('test', 'jsx-babel-automatic.js'),
-  // @ts-ignore Result always given.
+  // @ts-expect-error Result always given.
   babel
     .transformSync(doc.replace(/'name'/, "'jsx (babel, automatic)'"), {
       plugins: [

test/core.js

@@ -845,7 +845,6 @@ test('hastscript', (t) => {
     )
 
     t.deepEqual(
-      // @ts-ignore runtime.
       h('foo', {type: 'text/html', children: {bar: 'baz'}}),
       {
         type: 'element',
@@ -950,7 +949,7 @@ test('hastscript', (t) => {
 
     t.throws(
       () => {
-        // @ts-ignore runtime.
+        // @ts-expect-error runtime.
         h('foo', {}, true)
       },
       /Expected node, nodes, or string, got `true`/,

tsconfig.json

@@ -27,6 +27,7 @@
     "emitDeclarationOnly": true,
     "allowSyntheticDefaultImports": true,
     "skipLibCheck": true,
-    "strictNullChecks": true
+    "strictNullChecks": true,
+    "strict": true
   }
 }